Repository navigation
fix(memory): stop remember and the memory tool from losing or reviving memories - #585
Merged
Merged
Conversation
…g memories - remember with replace and no observations or note (or an empty list) is refused over MCP, HTTP and the CLI; before, it emptied the memory. - Over MCP, a project:<name> tag with no project argument is stored as the bound project id and reported in retagged; a bare project: tag is refused on every transport. - The memory tool treats a deleted memory as gone: view, str_replace, insert and a second delete no longer show or reactivate it. - A memory tool edit that leaves the text unchanged no longer raises its confidence or resets its observation times.
- The MCP and exported schemas now say a replace without observations is refused (minItems: 1), so an agent reading the schema no longer sends a call the server rejects. - The memory tool treats an edit that leaves the text the same as no edit, also when one stored observation holds a newline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four ways a memory could be lost or come back without being asked:
rememberwithreplace: trueand no content emptied the memory. A call that only meant to fix the title or tags (name+replace+title) cleared every observation, and the error text and the docs recommended exactly that call. It is now refused over MCP, HTTP and the CLI (an emptyobservationslist too); the message says to send the observations the memory already has with the new title.rememberwith a plainproject:<name>tag skipped the session binding, so the memory was filed under a project no briefing reads. It is now stored under the bound project id and reported inretagged, as the tool description already said. A bareproject:tag is refused on every transport.view,str_replace,insertand a seconddeleteon a deleted path now say it does not exist;createover the path still brings it back on purpose.Verified locally:
npm run verifygreen for the final tree; each fix has a test that fails when the fix is reverted.Refs #531