Conversation
Since OpenVoxProject#536 removed the default `server=puppet`, `create_service` raised (or warned) whenever `server` was not set in the config, even when the caller had already resolved a server through `server_list`, DNS SRV records, or an explicit `puppet://host/...` URL. An agent configured with only `server_list`, or with `use_srv_records` and `srv_domain`, could not connect at all. Move the check into `check_server_setting` and skip it when the resolver passes an explicit server. The settings-based resolver, which is the only one that falls back on `server`, keeps the existing errors and deprecation warning. Fixes OpenVoxProject#658 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
The `:ca` and `:report` services fall back on `ca_server` and `report_server` before `server`. When running as a non-privileged user those settings were already enough, but as root any missing `server` setting raised, and the deprecation warning fired even when the service-specific setting was configured. Check the service-specific settings first, for both root and non-root, so the two code paths agree on which setting is required. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com>
Contributor
Author
|
This PR is meant to stack on top of #659. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
The
:caand:reportservices fall back onca_serverandreport_serverbeforeserver. When running as a non-privileged user those settings were already enough, but as root any missingserversetting raised, and the deprecation warning fired even when the service-specific setting was configured.Check the service-specific settings first, for both root and non-root, so the two code paths agree on which setting is required.
Generated by Claude Code
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent