Skip to content

allow primary to clean jrubies code cache after code deployment - #640

Merged
bastelfreak merged 1 commit into
OpenVoxProject:mainfrom
marcusdots:main
Sep 17, 2026
Merged

bastelfreak merged 1 commit into
OpenVoxProject:mainfrom
marcusdots:main

Conversation

@marcusdots

Copy link
Copy Markdown
Contributor

On a default installation the primary should be able to clean its own code cache.
This enables OpenVox to work with r10k/g10k and a post deployment hook, e.g.

h=$(puppet config print certname)

curl -k -X DELETE \
  --cert /etc/puppetlabs/puppet/ssl/certs/$h.pem \
  --key  /etc/puppetlabs/puppet/ssl/private_keys/$h.pem \
  --cacert /etc/puppetlabs/puppet/ssl/ca/ca_crt.pem \
  https://$h:8140/puppet-admin-api/v1/environment-cache

Signed-off-by: Marcus Poller <marcus.poller@betadots.de>

@bastelfreak bastelfreak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sharpie @binford2k @silug do you have an objection here? IMO it makes sense to allow this in the default config.

@marcusdots after this is merged, we should update the template in the theforeman/puppe-puppet repo as well.

@bastelfreak bastelfreak added the enhancement New feature or request label Sep 17, 2026
@rwaffen

rwaffen commented Sep 17, 2026

Copy link
Copy Markdown
Member

LGTM

@bastelfreak
bastelfreak merged commit 4425ed3 into OpenVoxProject:main Sep 17, 2026
12 checks passed
@bastelfreak bastelfreak added the backport 8.x backports the merged PR to the 8.x branch label Sep 17, 2026
@OpenVoxProjectBot

Copy link
Copy Markdown
Collaborator

Successfully created backport PR for 8.x:

@Sharpie Sharpie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the best solution at the moment. Would be nice to have a dedicated permission for this, but that would also require everyone to update their certificates to add a new admin bit.

@nmburgan

Copy link
Copy Markdown
Member

Also note, I think upgrades aren't going to get the new rule because I believe auth.conf is a file that doesn't get replaced by the package, so people would have to add it manually. Also, this would need to be modfieid in packaging/resources/files/config/conf.d/auth.conf in the vanagon PR I have open at #643.

@marcusdots

Copy link
Copy Markdown
Contributor Author

@nmburgan I ported auth.conf to your branch:
535e164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 8.x backports the merged PR to the 8.x branch enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants