[Backport 5.x] Reject partial EC2 metadata results - #179
Open
OpenVoxProjectBot wants to merge 1 commit into
Open
OpenVoxProjectBot wants to merge 1 commit into
OpenVoxProjectBot wants to merge 1 commit into
Conversation
Resolve EC2 metadata with strict HTTP requests so a timeout, transport exception, or non-200 response aborts the entire recursive lookup. Build metadata separately and publish it only after every request succeeds. Previously, the shared HTTP helper converted failures to empty strings, making them indistinguishable from successful empty responses and allowing partially populated metadata to be cached. Keep successful 200 responses with empty bodies unchanged. Preserve the existing lenient HTTP helper for other callers, userdata behavior, and the EC2 cache lifetime. Add regression coverage for successful empty values, failed child requests, timeouts, and atomic publication. Assisted-by: OpenAI Codex:GPT-5 Signed-off-by: Daniel Juarez <djuarezg@proton.me> (cherry picked from commit aaca858)
OpenVoxProjectBot
enabled auto-merge
September 10, 2026 12:14
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #176 to
5.x.