Skip to content

Merge pull request #2705 from nxglabs/sync-to-public_repo-31391986146 - #2231

Merged
nxglabs merged 1 commit into
stagingfrom
updates-31399980715
Aug 10, 2026
Merged

nxglabs merged 1 commit into
stagingfrom
updates-31399980715

Conversation

@nxglabs

@nxglabs nxglabs commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Merge pull request #2704 from nxglabs/raktima-patch-main-7

Merge pull request #2704 from nxglabs/raktima-patch-main-7
Copilot AI lite review requested due to automatic review settings August 10, 2026 14:46
@vercel

vercel Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
open-sign Error Error Aug 10, 2026 2:47pm

@nxglabs
nxglabs merged commit 3729564 into staging Aug 10, 2026
5 of 6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to sync/merge upstream changes into the public repository, primarily updating Node/JS dependencies (including security-focused overrides) and expanding the PDF request/signing flow UI logic (public template + access-code/OTP related behavior), along with i18n string updates.

Changes:

  • Bump/downgrade several dependencies (e.g., axios, parse/parse-server, multer) and add multiple overrides entries in both server and client packages.
  • Add substantial logic to PdfRequestFiles.jsx around template fetching, subscription checks, OTP handling, and access-code verification.
  • Update access-code related translations across locales (min length wording + new show/hide strings in EN).

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
apps/OpenSignServer/package.json Dependency and overrides updates impacting runtime/toolchain requirements.
apps/OpenSignServer/package-lock.json Lockfile updates reflecting new dependency graph and engine constraints.
apps/OpenSign/src/pages/PdfRequestFiles.jsx Large behavioral changes for public template/signing flow, OTP, and access-code verification.
apps/OpenSign/src/components/pdf/SignerListPlace.jsx Minor formatting-only change.
apps/OpenSign/public/locales/*/translation.json Access-code text updates (min length wording), plus EN show/hide labels.
apps/OpenSign/package.json Client dependency bumps and new overrides entries.
Files not reviewed (1)
  • apps/OpenSignServer/package-lock.json: Generated file
Suppressed comments (3)

apps/OpenSign/src/pages/PdfRequestFiles.jsx:304

  • handleNavigation is defined with no parameters, but it's being called with res.plan here. If the plan is not used for navigation, call the function without arguments (or update handleNavigation to accept/use the plan).
        handleNavigation(res.plan);

apps/OpenSignServer/package.json:88

  • parse@8.1.0 (and the new overrides like undici@7.29.0 / brace-expansion@5.x) require Node >= 20, but this package still declares support for Node 18. This mismatch can lead to installs/builds failing or runtime incompatibilities for Node 18 users.
  "overrides": {
    "brace-expansion": ">=2.1.2",
    "ws": "$ws",
    "parse": "$parse",
    "form-data": "$form-data",
    "@parse/push-adapter": "$@parse/push-adapter",
    "fast-xml-builder": "1.2.0",
    "protobufjs": ">=7.6.3",
    "tmp": ">=0.2.7",
    "decompress": "npm:@xhmikosr/decompress@^11.1.4",
    "tar": "^7.5.19",
    "websocket-driver": ">=0.7.5",
    "js-yaml": "^3.15.0",
    "lodash": "^4.18.0",
    "undici": "^7.29.0"
  },
  "engines": {
    "node": "18 || 20 || 22"
  }

apps/OpenSign/package.json:161

  • This app depends on parse@^8.1.0 and overrides undici@^7.29.0, which require Node >= 20, but engines.node still lists Node 18. That can break local dev/CI environments that follow the declared Node 18 support.
  "overrides": {
    "brace-expansion": ">=2.1.2",
    "tmp": "$tmp",
    "react": "$react",
    "react-dom": "$react-dom",
    "form-data": ">=4.0.6",
    "js-yaml": "^3.15.0",
    "undici": "^7.29.0",
    "fast-uri": "^3.1.5"
  },
  "engines": {
    "node": "18 || 20 || 22"
  }

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +233 to +257
if (!docId || !signerObjId) {
throw new Error(t("something-went-wrong-mssg"));
}
const res = await Parse.Cloud.run("verifyAccessCode", {
docId,
signerObjId,
code
});
if (res?.verified) {
setAccessCodeVerified(true);
setAccessCodeRequired(false);
return true;
}
throw new Error(t("access-code-invalid"));
} catch (err) {
// Re-throw so the modal can render the message inline.
throw new Error(
err?.message === "Incorrect access code."
? t("access-code-invalid")
: err?.message || t("access-code-invalid")
);
} finally {
setAccessCodeLoader(false);
}
};
Comment on lines +1775 to +1798
}
setIsUiLoading(false);
} catch (e) {
console.log("e", e);
if (
e?.response?.data?.error === "Insufficient Credit" ||
e?.response?.data?.error === "Plan expired"
) {
handleCloseOtp();
setIsAlert({
title: t("insufficient-credits-title"),
isShow: true,
alertMessage: t("insufficient-credits-mssg", { appName })
});
} else {
handleCloseOtp();
setIsAlert({
title: "Error",
isShow: true,
alertMessage: t("something-went-wrong-mssg")
});
}
}
};
if (isGuestSign) {
setIsSubscriptionExpired(true);
} else {
handleNavigation(plan);
Comment on lines +331 to +332
//function for get document details for perticular signer with signer'object id
//whenever change anything in this function check react/angular packages also in plan js
nstankov-bg pushed a commit to Cargofort/OpenSign that referenced this pull request Sep 21, 2026
* build(deps-dev): bump picomatch

Bumps the npm_and_yarn group with 1 update in the / directory: [picomatch](https://github.com/micromatch/picomatch).


Updates `picomatch` from 2.3.1 to 2.3.2
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>

* Merge pull request #2460 from nxglabs/sync-to-public_repo-25861367352

Merge pull request #2459 from nxglabs/staging

* Merge pull request #2463 from nxglabs/sync-to-public_repo-26032162086

Merge pull request #2462 from nxglabs/staging

* Merge pull request #2467 from nxglabs/sync-to-public_repo-26233821722

Merge pull request #2466 from nxglabs/raktima-main-patch-5

* Merge pull request #2474 from nxglabs/sync-to-public_repo-26403170706

Merge pull request #2473 from nxglabs/raktima-patch-main-6

* Merge pull request #2576 from nxglabs/sync-to-public_repo-27677371306

Merge pull request #2575 from nxglabs/staging

* update package-lock.json file

* Merge pull request #2611 from nxglabs/sync-to-public_repo-28355409725

Merge pull request #2610 from nxglabs/staging

* Merge pull request #2611 from nxglabs/sync-to-public_repo-28355409725

Merge pull request #2610 from nxglabs/staging

* Merge pull request #2705 from nxglabs/sync-to-public_repo-31391986146 (OpenSignLabs#2231)

* Merge pull request #2707 from nxglabs/sync-to-public_repo-31405962035

Merge pull request #2706 from nxglabs/raktima-patch-main-7

* Merge pull request #2709 from nxglabs/sync-to-public_repo-31486925834

Merge pull request #2708 from nxglabs/raktima-patch-main-7

* v2.41.1 (OpenSignLabs#2233)

* Merge pull request #2717 from nxglabs/sync-to-public_repo-31818759561

Merge pull request #2716 from nxglabs/raktima-main-patch-security

* v2.41.2 (OpenSignLabs#2241)

* fix: update lockfile

* fix: update lockfile

* Merge pull request #2730 from nxglabs/sync-to-public_repo-32233884118

Merge pull request #2729 from nxglabs/raktima-main-patch-security

* Merge pull request #2737 from nxglabs/sync-to-public_repo-32459158600

Merge pull request #2736 from nxglabs/raktima-main-patch-security

* chore: pin MongoDB image to 7.0.43

Avoid unplanned upgrades from mongo:latest by locking the Compose service to a known 7.0 patch.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: raktima-opensignlabs <raktima-opensignlabs@users.noreply.github.com>
Co-authored-by: Raktima <110812506+raktima-opensignlabs@users.noreply.github.com>
Co-authored-by: RaktimaNXG <raktima.c@nxglabs.com>
Co-authored-by: Zathiel <26553418+Zathiel@users.noreply.github.com>
Co-authored-by: Amol <amol@qik.ai>
Co-authored-by: Cursor <cursoragent@cursor.com>

This branch had an error being deployed

1 failed deployment
Preview – open-sign — 32ecdd52 Deployed Aug 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants