Skip to content

bannertopdf: close output stream so the generated PDF is not truncated #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tillkamppeter merged 1 commit into from
Sep 14, 2026
Merged

bannertopdf: close output stream so the generated PDF is not truncated #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cupsfilters/bannertopdf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,6 +1021,14 @@ cfFilterBannerToPDF(int inputfd, // I - File descriptor input stream
unlink(tempfile);
if (inputfp)
fclose(inputfp);

// The output stream has to be flushed and closed here. When this filter
// function is called from cfFilterChain() (as the "universal" filter does),
// the parent closes the raw output file descriptor and exits right after
// this function returns, so a still buffered tail of the generated PDF
// (cross-reference table and "%%EOF") would be lost and the following
// filter in the chain would fail to parse the file.
if (outputfp)
fclose(outputfp);

return (ret);
}
Loading