Makefile.install: fix PKGFILE expression so it works with paths with spaces#5803
Open
Sid-MB wants to merge 1 commit intoOpenMathLib:developfrom
Open
Makefile.install: fix PKGFILE expression so it works with paths with spaces#5803Sid-MB wants to merge 1 commit intoOpenMathLib:developfrom
Sid-MB wants to merge 1 commit intoOpenMathLib:developfrom
Conversation
Note that the second setting of PKGFILE, at line 194, is redundant because that line was treated as a shell command which only assigned the variable for that line's invocation.
There was a problem hiding this comment.
Pull request overview
This PR fixes pkg-config file generation in Makefile.install when PREFIX (and thus derived paths) contains spaces, by ensuring PKGFILE is a proper Make variable containing an unquoted path rather than a shell-quoted string.
Changes:
- Define
PKGFILEas a Make variable (:=) without embedding quotes in its value, so later uses like>"$(PKGFILE)"work correctly with spaces. - Remove the later, ineffective
PKGFILE="..."assignment that was executed as a one-line shell assignment (and did not persist for subsequent recipe lines).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, running the make file with a PREFIX path which included spaces would write to the wrong path, now it will write to the correct path.
Also note that the second setting of PKGFILE, at line 194 previously, was useless because that line was treated as a shell command which only assigned the variable for that line's invocation.