fix(drivers/189pc,drivers/189tv): fix extra requests when viewing files#2791
Open
wzdc wants to merge 3 commits into
Open
fix(drivers/189pc,drivers/189tv): fix extra requests when viewing files#2791wzdc wants to merge 3 commits into
wzdc wants to merge 3 commits into
Conversation
jyxjjj
requested changes
Jul 15, 2026
jyxjjj
left a comment
Member
There was a problem hiding this comment.
建议复用请求时使用的 pageSize,避免再次硬编码 130 和 1000,否则以后修改分页大小时容易遗漏这里。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
原有代码中,翻页的终止条件只判断了 Count == 0(总数为0),但并未判断当前返回的文件数量是否未达到数量,导致额外请求获取下一页的文件。这里添加了判断返回的文件数量是否达到所设置的pageSize才触发请求下一页。
fileListAO.count获取的是当前文件夹下总共的文件数量而不是当前返回的文件数量,但实际测试发现:当你请求的页码超出实际范围时(比如总共只有 3 页,你却请求第 4 页),接口返回的 Count 变成了 0。
/ 此 PR 包含破坏性变更。
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
/ 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Testing / 测试
go test ./...Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。