Skip to content

chore: pin GitPython for release bump #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leongdl merged 1 commit into from
Aug 26, 2026
Merged

chore: pin GitPython for release bump #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion requirements-release.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
python-semantic-release == 10.6.*
python-semantic-release == 10.6.*
# GitPython 3.1.60 dropped Actor.name_email_regex, which python-semantic-release
# 10.6.1 still references; the release bump dies with
# "type object 'Actor' has no attribute 'name_email_regex'" before it does any
# git work. PSR depends on `gitpython~=3.0`, so the bad version floats in on a
# fresh install. Unpin once PSR ships a release compatible with 3.1.60+.
GitPython == 3.1.59

@github-actions github-actions Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin is likely to be silently reverted by the repository automation, reintroducing the exact breakage it guards against.

.github/dependabot.yml runs the pip ecosystem on directory /, which covers this file — it has bumped python-semantic-release here many times already. Once GitPython == 3.1.59 is a tracked requirement, Dependabot will propose 3.1.60, which is a patch bump and therefore matches the pip-minor-patch group. .github/workflows/auto_approve.yml then auto-approves any dependabot[bot] PR, so the unpin can land on an approval nobody actually read, and the next Release: Bump run dies again with Actor has no attribute name_email_regex.

The explanatory comment above the pin is genuinely useful for humans, but Dependabot does not read it. Consider pairing the pin with an ignore rule so the constraint is machine-enforced — under the pip entry in .github/dependabot.yml:

    ignore:
      - dependency-name: "gitpython"
        versions: [">=3.1.60"]

That also keeps the two places in sync: whoever removes the ignore rule has to look at the pin, and vice versa.

Loading