Fix log4j bad versions#389
Open
mgaffigan wants to merge 3 commits into
Open
Conversation
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
pacmano1 and
ssrowe
July 25, 2026 20:48
pacmano1
approved these changes
Jul 25, 2026
NicoPiel
approved these changes
Jul 26, 2026
tonygermano
reviewed
Jul 27, 2026
| <sha256 value="ba6d68eeab3a1cc13a77a8ade2197ff9a32aa1cffeac72847d49badd82e1b9ce" origin="Generated by Gradle"/> | ||
| </artifact> | ||
| </component> | ||
| <component group="com.fasterxml.jackson" name="jackson-bom" version="2.19.2"> |
Member
There was a problem hiding this comment.
Not sure what's going on with the jackson stuff. I don't think it is supposed to be in this PR? Additionally, this version doesn't match what is in libs.versions.toml, and there are already newer versions specified in this file.
Contributor
Author
There was a problem hiding this comment.
This was generated by the normal Gradle regen command. I assumed it had some interaction with another package or was missed in a prior PR.
Contributor
Author
There was a problem hiding this comment.
@tonygermano, is this blocking or are we good to merge?
jonbartels
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main (ac47cc8) has a bad combination of log4j libs which prevents the server from booting. They were not caught on #370 since #294 has not yet merged to start the server as part of CI, so approvers got happy green checkmarks when everything is broken.
Tested and passed with #294 and through manual tests.