[#60] Complete JPMS runtime compatibility through Java 25 - #123
Draft
peter-lawrey wants to merge 2 commits into
Draft
[#60] Complete JPMS runtime compatibility through Java 25#123peter-lawrey wants to merge 2 commits into
peter-lawrey wants to merge 2 commits into
Conversation
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final hardening stage for #60, stacked on #122 (which is stacked on #119).
This PR validates the explicit
net.openhft.hashingmodule through Java 25 while preserving the established direct-buffer fast path:LongHashFunctionfactory,LongTupleHashFunction.xx128(), arrays, heap and directByteBuffer,String,StringBuilder, and primitive arrays from a named consumer;sun.nio.ch.DirectBuffer.address()invocation; it does not introduce reflection or a reflective fallback;DirectBufferstub is not shipped;The consumer follows the repository convention: module
net.openhft.it.modulecontains packagenet.openhft.it.module.Runtime requirements
Direct-buffer hashing deliberately requires:
Without the relevant export, Java 25 raises
IllegalAccessError; that expected failure was reproduced for both deployment forms. There is no fallback to reflection.Java 25 also warns once per JVM when the library first invokes a terminally deprecated
sun.misc.Unsafememory-access method.--sun-misc-unsafe-memory-access=allowsuppresses that warning for applications which explicitly accept the temporary compatibility risk. Eliminating the dependency properly is not a small JPMS change and is outside this PR.Validation
Canonical artefact: the JAR produced by the Java 8 clean build was copied unchanged to
/tmp/zah60-stage3-jdk8.jar.mvn -B clean verify: passed; 14,901 tests, 12 skips; packaged-JAR tests and class-path consumer passed.ByteBuffer.net.openhft.hashing, including every public hash factory and directByteBuffer.8409002548710940386.mvn -B clean verify: passed; both 14,901-test executions, packaged-JAR tests, class-path consumer, and named-module consumer passed.jlinkimage built from the exact Java 8-built JAR: passed and includednet.openhft.hashingplusjdk.unsupported.jar --validate: passed.jar --describe-module --release 9: exports onlynet.openhft.hashing; requiresjdk.unsupported.META-INF/versions/9/module-info.classpresent;sun/nio/ch/DirectBuffer.classabsent.jdeps --multi-release 25 --jdk-internals: confirms the knownsun.misc.Unsafeandsun.nio.ch.DirectBufferdependencies; both are documented.warnpasses,allowpasses without the warning,debugidentifies all call sites, anddenyfails atUnsafeAccessinitialisation as expected.git diff --check: passed.The legacy Sonar workflow failure occurs before checkout because it still uses a retired action. Workflow/Sonar maintenance is deliberately a separate concern and this PR does not modify it.
Stack and merge order
After #119 and #122 merge, this PR should be rebased or retargeted to
developwithout changing the packaging mechanism established by #122.Fixes #60