Don't commit credentials.yaml in gh sync#1420
Merged
Merged
Conversation
josephjclark
changed the title
Collaborator
Author
|
Weird test fails here making me nervous. I'll pick this up in the morning with a clear head. |
josephjclark
commented
May 22, 2026
| project: options.projectId, | ||
| force: true, | ||
| endpoint: config.endpoint, | ||
| apiKey: config.apiKey, |
Collaborator
Author
There was a problem hiding this comment.
I don't understand why I had to add this (it hasn't worked anyway), but I'm also a bit surprised it wasn't there any way. I guess GH sync uses an env var so its not really needed.
But I think I want to leave it in
Collaborator
Author
|
Ok, works great pulling and pushing to staging.openfn.org using the v1 commands and an openfn.yaml file. Confident that this small change is very safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
This PR ensures that the v2 sync proxy used by GH sync does NOT generate a credentials.yaml file.
Users are free to use this of course, but it should not be checked in to GH by default
Fixes #1419
A lot of the work here has been in updating the pull and deploy tests so I can cover credentials.yaml usage
QA Notes
Needs testing against prod one relesaed
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy