Conversation
Reworked serial write pacing to use a target end time with calibrated fudge factors, combining coarse sleep and final busy-wait for better timing accuracy across short and long delays. The transmission wait API was simplified (no external start time), timing constants were normalized to doubles, and interruption/runtime issues during wait are now handled without breaking write flow.
da-Kai
changed the title
Adjusts Modbus serial transmit pacing to use `LockSupport.parkNanos` for long waits and revises the sleep threshold/margin logic for better timing precision.
Replaces fixed long/short transmission fudge factors with a calibrated power-law wait model and explicit min/max bounds. It also adds timing thresholds for parkNanos vs busy-wait behavior, with updated comments explaining the empirical tuning for serial timing on constrained Linux/USB-RS485 setups.
da-Kai
marked this pull request as ready for review
September 9, 2026 05:37
Howaner
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix serial timing and refactor transmission delay handling