fix(release): accept the .publish.attestation sidecars the publish action writes - #327
Merged
Merged
Conversation
…tion writes pypa/gh-action-pypi-publish writes <distribution>.publish.attestation beside each file it uploads. The post-publication step 'Verify immutable PyPI publication bytes' runs scripts/verify_pypi_release.py on the same dist/ directory afterwards, and that script refused the sidecars as unexpected local distributions. On the v0.95.1 tag push (run 33572718878) the upload succeeded, the verification step failed, and the GitHub release job never ran. The sidecars are skipped; the wheel and sdist are still required and still compared byte for byte. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pypa/gh-action-pypi-publishwrites<distribution>.publish.attestationbeside each file it uploads. The release workflow then runsscripts/verify_pypi_release.pyon that samedist/directory ("Verify immutable PyPI publication bytes"), and the script refuses any file that is not the wheel or the sdist. On thev0.95.1tag push (run 33572718878) the upload succeeded,0.95.1is on PyPI, the verification step failed on the sidecar, andpublish-github-releasenever ran. So there is no GitHub release forv0.95.1.The published bytes were verified another way: a local
uv build --no-sourcesof thev0.95.1tag produced a wheel and sdist thatscripts/verify_pypi_release.py --version 0.95.1matched against PyPI byte for byte (wheel65eb9509…, sdist96858802…).What changes:
_local_artifactsskips files ending in.publish.attestation. The wheel and sdist are still required by name and still compared by hash and by body. One test pins it.What a reviewer should check: whether skipping a sidecar can hide a wrong artifact. It cannot, because the skip is by suffix and the two real distributions are still mandatory.
After this lands the proposal bot will open
chore(release): prepare 0.95.2. Publishing that is the first release where both post-#303 gates pass end to end and a GitHub release is created.Opened by an agent session, not the founder.
🤖 Generated with Claude Code