fix(release): accept the dist/.gitignore marker uv build writes - #323
Merged
Conversation
uv build writes a one-line `*` .gitignore into a dist/ directory it creates. scripts/verify_pypi_release.py, added in #303, refused any non-distribution file in dist/, so the first tag-push release after #303 (v0.95.0, run 33571911895) stopped at 'unexpected local distribution: .gitignore' before publishing. The marker with exactly that content is skipped; any other hidden file in dist/ is still refused. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv buildwrites a one-line*.gitignoreinto adist/directory it creates, so build output never gets committed.scripts/verify_pypi_release.py(added in #303) refuses any file indist/that is not a wheel or an sdist. The two met for the first time on thev0.95.0tag push: run 33571911895 built the tag, passed the source-boundary gate, and stopped atunexpected local distribution: .gitignorebefore anything reached PyPI. The tag exists;0.95.0is not on PyPI and never will be, since the fix has to live in the tagged tree.What changes:
_local_artifactsskips a file named.gitignorewhose content is exactly*. Anything else hidden indist/is still refused, and two tests pin both halves.What a reviewer should check: that skipping the marker cannot hide a real artifact. It cannot, because the skip is keyed on name and full content, and the wheel and sdist are still required by name.
After this lands the proposal bot will open
chore(release): prepare 0.95.1; that is the version the Prime Intellect environment in the next PR pins.Opened by an agent session, not the founder.
🤖 Generated with Claude Code