fix: bind Flow admission candidates to retained trial outcomes - #38
Merged
Conversation
Signed-off-by: abrichr <richard.abrich@mldsai.com>
Signed-off-by: abrichr <richard.abrich@mldsai.com>
Signed-off-by: abrichr <richard.abrich@mldsai.com>
Signed-off-by: abrichr <richard.abrich@mldsai.com>
Signed-off-by: abrichr <richard.abrich@mldsai.com>
Signed-off-by: abrichr <richard.abrich@mldsai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing Flow admission names 1.34.0. The published 1.35.0 wheel has retained failures in attended continuation and encrypted repair, so this change keeps its candidate explicitly incomplete.
The candidate builder verifies retained artifact hashes, derives campaign totals from individual observations, and checks each trial's required events. It compares normalized outcomes with native runtime reports and checks every installed runtime member against the exact wheel. A decision receipt cannot turn
COMPLETED_UNVERIFIEDinto a verified effect.The unpublished 1.35.1 successor now passes the verifier with 36 selected trial groups and 1,617 inventoried artifacts. The retained candidate reports
ready-for-release-review, with publication and admission still false. It binds sourceaed32758b7342c61787a3b56fe940e1e9f2d648aand measured manifestsha256:2cd3b47a9c1fc3d81b1207e7f64441d82ad7f0f62babf49d8ffde6ae2ac2c7ca. Reviewers must examine the retained measurement code and independent oracle evidence before accepting it. These consistency checks don't establish that a process executed or grant release authority.Validation: 24 focused tests pass. Independent review reproduced and closed mismatched-observation counts, events concentrated in one trial, omitted normalizer source, native unverified outcomes, altered installed members, and incorrect runtime identity. Lint and format checks pass. All 294 repository unittest checks pass with the standard test runner.
The 42 complete raw trial groups include six named exclusions and retain 54 native phase reports. Two incomplete repair instrumentation/restart attempts also remain retained and excluded. Safe-halt class membership overlaps with reconciliation-required outcomes; these counts do not define an aggregate success percentage. The candidate README records the exact selection and both remaining identity-OCR limitations.
The builder has no key access or registry writes. Merge, protected-main qualification, immutable publication, artifact parity, and admission issuance remain separate required actions.
Opened by an agent session, not the founder.