refactor server.py for using Blueprint#3033
Open
JanEisermann wants to merge 66 commits into
Open
Conversation
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
requested changes
Mar 20, 2026
ReimarBauer
left a comment
ReimarBauer
left a comment
Member
There was a problem hiding this comment.
That's good progress. We can already see it's becoming much more readable. You need to rearrange a few things.
The blueprints should contain as few additional functions as possible.
Especially not ones that need to be imported from other blueprints.
see comments
JanEisermann
force-pushed
the
inkludingBP
branch
from
efd14d0 to
570f809
Compare
ReimarBauer
reviewed
Mar 24, 2026
| @@ -32,7 +32,7 @@ <h3>Reset Password</h3> | |||
| </div> | |||
| {% if uri is defined %} | |||
Member
There was a problem hiding this comment.
maybe the name should be changed from status.html to status_password.html
status has too much meanings
ReimarBauer
reviewed
Mar 24, 2026
|
|
||
| mslib.mscolab.blueprints.auth.auth | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
Member
There was a problem hiding this comment.
mslib.mscolab.blueprints.auth
ReimarBauer
reviewed
Mar 24, 2026
| """ | ||
|
|
||
| mslib.mscolab.blueprints.docs.docs | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
Member
There was a problem hiding this comment.
mslib.mscolab.blueprints.docs
look also on the others
ReimarBauer
reviewed
Mar 24, 2026
| return _app, sockio, cm, fm, mail | ||
|
|
||
|
|
||
| @APP.route('/') |
Member
There was a problem hiding this comment.
this has to go to bp docs
ReimarBauer
reviewed
Mar 24, 2026
|
|
||
|
|
||
| @APP.route('/uploads/<name>/<path:filename>', methods=["GET"]) | ||
| def uploads(name=None, filename=None): |
Member
There was a problem hiding this comment.
this has to go to bp chat
ReimarBauer
reviewed
Mar 24, 2026
| return render_template("docs/index.html") | ||
|
|
||
|
|
||
| @APP.route("/status") |
ReimarBauer
reviewed
Mar 24, 2026
| @@ -17,13 +17,13 @@ | |||
| <div class="container-fluid"> | |||
| <div class="row" style="background-color:lavender;"> | |||
| {% if file_exists(imprint) %} | |||
Member
There was a problem hiding this comment.
the file has to go to mscolab.blueprints.docs.templates and msmw.blueprints.docs.templates
one move one copy
ReimarBauer
reviewed
Mar 24, 2026
| @@ -8,9 +8,9 @@ | |||
| <meta name="description" content="Mission Support System"> | |||
| <meta name="keywords" content="MSS, MSCOLAB"> | |||
| <meta name="author" content="authors of MSS"> | |||
| <link rel='shortcut icon' type='image/x-icon' href="{{ url_for('favicons') }}"> | |||
| <link rel='shortcut icon' type='image/x-icon' href="{{ url_for('docs.favicons') }}"> | |||
| <title>Mission Support System Collaboration Platform</title><!-- Bootstrap core CSS --> | |||
Member
There was a problem hiding this comment.
the file has to go to mscolab.blueprints.docs.templates and msmw.blueprints.docs.templates
one move one copy
ReimarBauer
reviewed
Mar 24, 2026
| @@ -28,13 +28,21 @@ | |||
| import logging | |||
…asic_auth'] (does not work at the moment)
…lask's from_object() and can land in app.config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2081
Does this PR introduce a breaking change?
included Blueprint, fixed test_load_no_file
If the changes in this PR are manually verified, list down the scenarios covered::
tests succeed, not manually verified
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>