Develop#39
Merged
Merged
Conversation
Switched expand_minimal_json_to_full_json(...) in src/flexo_syside_lib/core.py:289 to the direct non-textual path: json.loads -> Sema.resolve -> serialize That keeps implied relationships without round-tripping through textual SysML. I also updated the tests in tests/test_core.py:454 to match the new behavior. DeserializedModel.link(...) is too narrow for this because it only resolves pending references. The public API that matches your need is syside.Sema.resolve(...), whose doc says it will “Link and resolve semantic rules for documents”. That is the missing step for implied relationships. SerializationOptions.include_implied=True only affects what gets emitted during serialization; it does not create implied elements by itself. In practice, this worked locally on your sample: 1. syside.json.loads(...) 2. syside.Sema().resolve([deserialized_model.document], env.index(), env.lib, reporter) 3. syside.serialize(..., options_with_include_implied=True) That restored the implied Subclassification without going through textual SysML.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.