fix: [SDK-5313] run in-app message trigger and pause changes on the main queue

[nan-li]

Description

One Line Summary

Run in-app trigger changes and pause evaluation on the main queue, where the message state already lives. SDK-5313, fixes #1753.

Details

Motivation

addTriggers, removeTriggers, clearTriggers and unpausing evaluated messages on the calling thread. They read messages, redisplayedInAppMessages and earlySessionTriggers without a lock. Meanwhile, the fetch completion and dismiss path write to the same state on the main queue.

React Native calls these methods from a background queue. If the operations overlap, the app crashes in evaluateRedisplayedInAppMessages with EXC_BAD_ACCESS.

Scope

• The new runOnMainQueue: method in OSMessagingController runs a block inline on the main thread or dispatches it asynchronously from any other thread.
• addTriggers:, removeTriggersForKeys: and clearTriggers run their bodies through the helper.
• clearTriggers reads the keys inside the block, so it also clears a trigger queued immediately before it.
• setInAppMessagingPaused: still sets the flag synchronously, which means paused reads back immediately. The evaluation runs through the helper, and so does the check for a showing message before a dismiss is queued. A main-thread caller runs that check at call time, as before.
• messageIsNotActive: deletes the message inside the main-queue block it already used for the window cleanup. The HTML request fails on the session queue, so the delete used to replace messages off main too.
• Callers already on the main thread see no change. Neither the public API nor requests change.

Testing

Unit testing

TriggerThreadingTests seeds one message with redisplay state, calls each entry point from a global queue while holding the main thread, then drains the main queue. The add and remove tests verify that the redisplay check and the trigger controller aren't touched on the calling thread and run on the main thread afterward. The clear test verifies the same for the trigger controller and that a trigger queued from the same background call just before it is removed. The unpause test verifies the flag reads back immediately and that evaluation runs on the main thread. All four fail without this fix.

testPreviewIAMIsDisplayedOnPause now drains the main queue before its assertion, so a pause that wrongly queues a dismiss with nothing showing fails it.

Manual testing

The OneSignalInAppMessagesTests bundle ran locally on an iPhone 17 Pro simulator with Xcode 27. Not run on a device.

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code