-
Notifications
You must be signed in to change notification settings - Fork 265
feat: [JWT-8] demo app Identity Verification UI #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
20d6bd3
feat: [PR8] demo app Identity Verification UI
nan-li 11dd0d4
fix: [JWT-8] surface the SDK's JWT ask in the demo instead of re-logg…
nan-li 6db4e7d
fix: [JWT-8] only save the demo bearer when the JWT is for the curren…
nan-li 1f5f7a0
fix: [JWT-8] keep the demo bearer and refetch on a same-user login
nan-li 4ea6caf
fix: [JWT-8] relabel the fetch toggle, refetch on flip, and show the …
nan-li 70d5450
style: [JWT-8] split the demo view model to clear the SwiftLint error
nan-li 5edbe37
fix: [JWT-8] refetch the demo /users call after PROVIDE JWT
nan-li File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev-only, but this still writes a bearer to
UserDefaults.standard(backups, anyone dumping defaults). It also teaches an unsafe pattern.I’d keep it in memory for the process, or Keychain. The update path already prints
Updated JWT for:without the token, which is the right instinct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not addressing. Same reasoning as on #1709. The token is valid for at most 1 hour, and the SDK itself keeps it across a relaunch on purpose, so the demo keeping it for its REST fetch matches that.