Skip to content

Publish UnifiedRT into Core: remove LightTransport package, keep 6000.0–6000.3 compatible#60

Open
TrevorDaschOculus wants to merge 1 commit into
6000.0/oculus-app-spacewarpfrom
6000.0/oculus-app-spacewarp-urt-merge
Open

Publish UnifiedRT into Core: remove LightTransport package, keep 6000.0–6000.3 compatible#60
TrevorDaschOculus wants to merge 1 commit into
6000.0/oculus-app-spacewarpfrom
6000.0/oculus-app-spacewarp-urt-merge

Conversation

@TrevorDaschOculus

Copy link
Copy Markdown
Collaborator

Publish UnifiedRT Step 2: Removing the LightTransport package and putting its content in com.unity.render-pipelines.core

Cherry-picked from 4c2f15f.

Conflict resolution: took the incoming UnifiedRayTracing/Sampling package content wholesale, and dropped the now-removed com.unity.rendering.light-transport dependency from the SRP test project manifests (the package no longer exists on disk).

Also migrated the APV baking consumers (ProbeGIBaking.SkyOcclusion/RenderingLayers/ VirtualOffset/LightTransport) to the new package API so the 6000.0 branch compiles:

  • SamplingResources.BindSobolBlueNoiseTextures -> SamplingResources.Bind
  • AccelStructAdapter.AddInstance now takes a per-submesh isOpaque span (all true, preserving the previous MeshInstanceDesc.opaqueGeometry default)

Verified compiling on Unity 6000.0.23f1, 6000.0.67f1, 6000.2.5f1, 6000.2.12f1 and 6000.3.2f1.

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

…ting its content in com.unity.render-pipelines.core

Cherry-picked from 4c2f15f.

Conflict resolution: took the incoming UnifiedRayTracing/Sampling package
content wholesale, and dropped the now-removed com.unity.rendering.light-transport
dependency from the SRP test project manifests (the package no longer exists on disk).

Also migrated the APV baking consumers (ProbeGIBaking.SkyOcclusion/RenderingLayers/
VirtualOffset/LightTransport) to the new package API so the 6000.0 branch compiles:
- SamplingResources.BindSobolBlueNoiseTextures -> SamplingResources.Bind
- AccelStructAdapter.AddInstance now takes a per-submesh isOpaque span (all true,
  preserving the previous MeshInstanceDesc.opaqueGeometry default)

Verified compiling on Unity 6000.0.23f1, 6000.0.67f1, 6000.2.5f1, 6000.2.12f1 and 6000.3.2f1.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant