Publish UnifiedRT into Core: remove LightTransport package, keep 6000.0–6000.3 compatible#60
Open
TrevorDaschOculus wants to merge 1 commit into
Conversation
…ting its content in com.unity.render-pipelines.core Cherry-picked from 4c2f15f. Conflict resolution: took the incoming UnifiedRayTracing/Sampling package content wholesale, and dropped the now-removed com.unity.rendering.light-transport dependency from the SRP test project manifests (the package no longer exists on disk). Also migrated the APV baking consumers (ProbeGIBaking.SkyOcclusion/RenderingLayers/ VirtualOffset/LightTransport) to the new package API so the 6000.0 branch compiles: - SamplingResources.BindSobolBlueNoiseTextures -> SamplingResources.Bind - AccelStructAdapter.AddInstance now takes a per-submesh isOpaque span (all true, preserving the previous MeshInstanceDesc.opaqueGeometry default) Verified compiling on Unity 6000.0.23f1, 6000.0.67f1, 6000.2.5f1, 6000.2.12f1 and 6000.3.2f1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish UnifiedRT Step 2: Removing the LightTransport package and putting its content in com.unity.render-pipelines.core
Cherry-picked from 4c2f15f.
Conflict resolution: took the incoming UnifiedRayTracing/Sampling package content wholesale, and dropped the now-removed com.unity.rendering.light-transport dependency from the SRP test project manifests (the package no longer exists on disk).
Also migrated the APV baking consumers (ProbeGIBaking.SkyOcclusion/RenderingLayers/ VirtualOffset/LightTransport) to the new package API so the 6000.0 branch compiles:
Verified compiling on Unity 6000.0.23f1, 6000.0.67f1, 6000.2.5f1, 6000.2.12f1 and 6000.3.2f1.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.