chore: remove the no-op Skip Tests workflow

[NickJosevski]

The problem

Branch protection on main requires a status check named test. Two workflows publish a check by that name, from the same app: the real job in integration-tests.yml, and skip-test.yml, whose entire body is:

- run: 'echo "No build required" '

They collapse onto a single required context, resolved by whichever finishes last. The integration job takes ~3 minutes and the no-op takes ~2 seconds, so today the real result usually wins — but the merge gate for main is being decided by job duration rather than by policy.

The shared name was deliberate. Both triggers are broken.

Naming both jobs test is the usual workaround for pairing a required check with a path filter: supply a green test on docs-only PRs when the real job is skipped. That's why renaming the job is the wrong fix — it would leave docs-only PRs with no test check at all, so the required context would never report and the PR could never merge.

The problem is that neither trigger does what it was meant to:

• integration-tests.yml applies paths-ignore to push only — its pull_request trigger is unfiltered, so the real job already runs on docs-only PRs.
• skip-test.yml filters on path:, which is not a valid key (it should be paths:), so the no-op runs on every PR and is always green.

Why repairing the triggers isn't enough

paths-ignore fires when any changed file falls outside the pattern; paths fires when any changed file matches it. A PR touching both .md and .go files satisfies both conditions, so both workflows would still run and the collision would return.

This change

Delete the no-op workflow. Exactly one check named test remains, so the required context always reflects a real run.

Docs-only PRs now run the full suite — about three minutes. That seems a fair price for a merge gate that means what it says, and this repo does not see many docs-only PRs.

Related

While looking at CI I found that fork PRs can never satisfy this check at all: integration-tests.yml needs secrets.DB_IMAGE_SA_PASSWORD, OD_IMAGE_ADMIN_API_KEY and OCTOPUS_SERVER_BASE64_LICENSE, and GitHub withholds secrets from pull_request runs originating on a fork. The job dies at Initialize containers before any Go runs. That affects #435, #436, #433, #430, #298, #399 and #400, and across the last 200 merged PRs only 2 came from forks — both from December 2023. Worth a follow-up to split the workflow so fork PRs get a real test result, with the container job gated behind an Environment with required reviewers. Not in scope here.