fix: error when a deployment process link cannot be resolved - #446
Draft
NickJosevski wants to merge 1 commit into
Draft
fix: error when a deployment process link cannot be resolved#446NickJosevski wants to merge 1 commit into
NickJosevski wants to merge 1 commit into
Conversation
Get, GetTemplate, GetDeploymentProcessByGitRef and GetDeploymentProcessTemplate discarded the errors from Parse and Expand. An unpopulated Links map produced an empty path that resolved to the API root and unmarshalled into a zero-valued resource, returning a nil error. Fixes #444 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get,GetTemplate,GetDeploymentProcessByGitRefandGetDeploymentProcessTemplateall discarded the errors fromuritemplates.Parseandtemplate.Expand. When aProjectorDeploymentProcesshas an unpopulatedLinksmap,Parse("")succeeds,Expandreturns"", and the GET resolves to the API root — which unmarshals cleanly into a zero-valued resource. The caller got a non-nil result and a nil error.Adds an
expandLinkhelper that errors when the link is absent, matching the existing wording inProjectService.ConvertToVcs.Verified live:
Happy paths unchanged against a real instance — CaC with an explicit gitRef, CaC with the default-branch fallback, non-CaC, the newclient equivalent, and
GetTemplateall still return their processes. New tests fail without the source change.Fixes #444
🤖 Generated with Claude Code