feat: expand the serverstatus API surface - #440
Merged
Conversation
NickJosevski
marked this pull request as ready for review
August 7, 2026 05:22
NickJosevski
force-pushed
the
nj/serverstatus-endpoints
branch
from
August 10, 2026 06:51
e5b3f5e to
ec8c550
Compare
YuKitsune
reviewed
Aug 10, 2026
YuKitsune
left a comment
YuKitsune
left a comment
Contributor
There was a problem hiding this comment.
Server status stuff looks good, not sure about the action template stuff though. Is that an unrelated change that snuck in?
| // input query parameter. | ||
| func GetByQuery(client newclient.Client, spaceID string, actionTemplatesQuery Query) (*resources.Resources[*ActionTemplate], error) { | ||
| return newclient.GetByQuery[ActionTemplate](client, template, spaceID, actionTemplatesQuery) | ||
| } |
Contributor
There was a problem hiding this comment.
These changes don't seem related.
Contributor
Author
There was a problem hiding this comment.
good catch removed now
Adds GetServerStatus, GetHealthStatus, GetTimezones and GetDocumentCounts as newclient functions, and the missing IsPotentialClone field on ServerStatus. Shapes verified against a live server. Refs #47 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Adds GetSystemInfo, GetRecentLogs and GetSystemReport. The report is a zip archive, so it returns an io.ReadCloser. All three require the AdministerSystem permission. Shapes verified against a live server. Refs #47 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
force-pushed
the
nj/serverstatus-endpoints
branch
from
August 11, 2026 01:39
ec8c550 to
375764f
Compare
sathvikkumar-octo
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #47.
ServerStatusServiceexposed onlyGet. Adds newclient functions for every endpoint on theServerStatusresource:GetServerStatus/api/serverstatusGetHealthStatus/api/serverstatus/healthGetTimezones/api/serverstatus/timezonesGetDocumentCounts/api/serverstatus/countsGetSystemInfo/api/serverstatus/system-infoGetRecentLogs/api/serverstatus/logs{?skip,take,includeDetail}GetSystemReport/api/serverstatus/system-reportAlso adds the missing
IsPotentialClonefield onServerStatus.Notes:
GetSystemReportreturns anio.ReadCloser— the endpoint serves a zip archive, not JSON. The caller closes it.GetSystemInfo,GetRecentLogsandGetSystemReportrequire theAdministerSystempermission.SystemInfo.Uptimeis left as the server's time span string;FromTimeSpanlives inmachinepolicies/machines, so parsing it here would mean importing one of those./api/serverstatus/extensionsis not included; it 404s and is not advertised on the resource.All response shapes verified against a live server. e2e tests cover all seven, and unit tests pin the
LogsQueryexpansion.