fix: add actiontemplates.GetByQuery so collection filters reach the server - #439
Merged
Conversation
…erver ActionTemplateSearch is the response shape of Search and carries no uri tags, so the fields passed to Get never reached the server and every call returned the default first page. Deprecate Get and add GetByQuery, which takes the existing Query. Fixes #437 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
force-pushed
the
nj/actiontemplates-get-by-query
branch
from
August 12, 2026 00:57
b1ba0e9 to
24994e7
Compare
NickJosevski
marked this pull request as ready for review
August 12, 2026 01:02
YuKitsune
reviewed
Aug 12, 2026
YuKitsune
left a comment
YuKitsune
left a comment
Contributor
There was a problem hiding this comment.
Code is fine but the comments have some Claude-isms
Co-authored-by: Eoin Motherway <25342760+YuKitsune@users.noreply.github.com>
Co-authored-by: Eoin Motherway <25342760+YuKitsune@users.noreply.github.com>
Contributor
Author
|
@YuKitsune thank you! |
YuKitsune
approved these changes
Aug 12, 2026
NickJosevski
enabled auto-merge (rebase)
August 12, 2026 02:20
NickJosevski
disabled auto-merge
August 12, 2026 02:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437.
ActionTemplateSearchis the response shape ofSearchand carries nouritags, so the fields passed toGetnever reached the server — every call returned the default first page.GetByQuery, taking the existingQuery(which has the correct tags)Get, left in place and unchanged