Skip to content

Fix the inconsistency of port [Fixes #1646] - #1648

Open
Aarush289 wants to merge 1 commit into
OWASP:masterfrom
Aarush289:port_inconsistency_fix
Open

Fix the inconsistency of port [Fixes #1646]#1648
Aarush289 wants to merge 1 commit into
OWASP:masterfrom
Aarush289:port_inconsistency_fix

Conversation

@Aarush289

@Aarush289 Aarush289 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Proposed change

This PR fixes #1646

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change that fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Documentation/localization improvement
  • Test coverage improvement
  • Dependency upgrade
  • Other improvement (best practice, cleanup, optimization, etc)

Checklist

  • I've followed the contributing guidelines
  • I've digitally signed all my commits in this PR
  • I've run make pre-commit and confirm it didn't generate any warnings/changes
  • I've run make test and I confirm all tests passed locally
  • I've added/updated any relevant documentation in the docs/ folder
  • I've linked this PR with an open issue
  • I've tested and verified that my code works as intended and resolves the issue as described
  • I've attached screenshots demonstrating that my code works as intended (if applicable)
  • I've checked all other open PRs to avoid submitting duplicate work
  • I confirm that the code and comments in this PR are not direct unreviewed outputs of AI
  • I confirm that I am the Sole Responsible Author for every line of code, comment, and design decision

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 593be103-f690-43c4-88b1-2099d79828d1

📥 Commits

Reviewing files that changed from the base of the PR and between 9fa9645 and a315480.

📒 Files selected for processing (1)
  • nettacker/core/lib/base.py

Summary by CodeRabbit

  • Bug Fixes
    • Temporary event records now correctly capture port information from available port fields or URLs.
    • Improved handling of events where port details were previously missing or incomplete.

Walkthrough

Temporary-event database records now derive port from ports, port, or a numeric port parsed from url. The logic uses an empty value when no port is available.

Changes

Temporary-event port handling

Layer / File(s) Summary
Port selection fallback
nettacker/core/lib/base.py
Temporary-event submissions select the port from ports or port, then fall back to a numeric port parsed from url or an empty value.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: arkid15r, securestep9

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Contribution validation failed:

  • issue_reference: This PR must be linked to an issue or include a valid closing issue reference in the description.

@github-actions github-actions Bot closed this Aug 5, 2026
@Aarush289

Copy link
Copy Markdown
Contributor Author

@securestep9 please reopen this PR

@securestep9

Copy link
Copy Markdown
Collaborator

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3154808d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread nettacker/core/lib/base.py
Comment thread nettacker/core/lib/base.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent port extraction in process_conditions() in base.py

3 participants