Skip to content

[16.0][ADD] fastapi_auth_jwt, fastapi_auth_jwt_demo#347

Merged
OCA-git-bot merged 4 commits into
OCA:16.0from
acsone:16.0-fastapi_auth_jwt
Jun 26, 2023
Merged

[16.0][ADD] fastapi_auth_jwt, fastapi_auth_jwt_demo#347
OCA-git-bot merged 4 commits into
OCA:16.0from
acsone:16.0-fastapi_auth_jwt

Conversation

@sbidoul

@sbidoul sbidoul commented Jun 15, 2023

Copy link
Copy Markdown
Member

The fastapi_auth_jwt module provides FastAPI dependencies to allow authentication with auth_jwt.

See USAGE.rstfor more information.

Sill draft as I have some doubts about the best structure of the dependencies.

  • Should they be classes where the JWT validator name can be configured or should we rely exclusively on FastAPI depends overrides to select the JWT validator. => classes remain but the public API is the functions
  • Not sure what to do about the odoo environment dependency... => added auth_jwt_authenticated_odoo_env
  • depends on [16.0] auth_jwt: add cookie mode server-auth#520

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch from 122c47d to 5194c59 Compare June 15, 2023 16:50
@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch 2 times, most recently from 8657a25 to b006c89 Compare June 16, 2023 15:56
@sbidoul sbidoul marked this pull request as ready for review June 16, 2023 16:02
Comment thread fastapi_auth_jwt_demo/tests/test_fastapi_auth_jwt_demo.py Outdated
@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch from 1f53221 to 89513b2 Compare June 19, 2023 13:02
Comment thread fastapi_auth_jwt_demo/tests/test_fastapi_auth_jwt_demo.py Outdated
@sbidoul sbidoul force-pushed the 16.0-fastapi_auth_jwt branch 3 times, most recently from ab7a012 to 7df3ff7 Compare June 19, 2023 16:21
@sbidoul

sbidoul commented Jun 19, 2023

Copy link
Copy Markdown
Member Author

🍏 😅

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Codre review and basic functional tests)

@sbidoul

sbidoul commented Jun 26, 2023

Copy link
Copy Markdown
Member Author

Ok, let's go with this.

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-347-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 48c1762 into OCA:16.0 Jun 26, 2023
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b03d3b5. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants