update deps for flutter 3.44.+ - #173
Merged
Merged
Conversation
ddfreiling
approved these changes
Jul 2, 2026
Also adds a skill for this.
ddfreiling
reviewed
Aug 6, 2026
| | DiViNa | ✓ | — | ✓¹ | ✓¹ (Guided Navigation) | | ||
|
|
||
| ¹ DiViNa audio narration is driven by a Guided Navigation document and synchronises at the page | ||
| ² DiViNa audio narration is driven by a Guided Navigation document and synchronizes at the page |
The DerivedData cache key hashed .flutter-version, but `restore-keys` used the bare `xcode-deriveddata-macos26-` prefix, so a bump of the Flutter pin fell back to a tree built against the previous engine. Its cached bridging-header .pch was compiled against the old Flutter.framework headers, and `flutter build ios` then copies the new engine's framework into example/build/ — so clang failed with "FlutterPlugin.h has been modified since the precompiled header was built" instead of rebuilding it. Move the Flutter version into the key prefix so partial restores stay within one engine version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The test waited only for the href to match before asserting on cssSelector. onTextLocatorChanged has two producers on Android: onVisualCurrentLocationChanged emits the raw navigator locator, while emitOnPageChanged emits the enriched one that actually carries cssSelector. On a slow emulator the raw locator satisfied the href wait first, so the assertion read a null selector ~44ms before the enriched emission landed. Wait on the selector as well as the href. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Gate the Dart-side log listener behind --dart-define=READIUM_TEST_SKIP_LOGS, set only in the three CI workflows: the DEBUG/INFO firehose (a few hundred bytes per locator event) buries the reporter output there and gets throttled by debugPrint anyway. WARN/ERROR still print. Local runs (VSCode launch configs, per-test gutter buttons) pass no define and stay verbose. Filtering happens in the listener rather than via Logger.root.level because setLogLevel(debug) enables hierarchical logging and sets the flutter_readium logger's own level, after which the root level no longer gates its records. The native log level is untouched, so the Android logcat artifact uploaded on failure retains full detail. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.