Skip to content

Fix access list expansion when enabling proxy hosts#5711

Open
CarminKern wants to merge 1 commit into
NginxProxyManager:developfrom
CarminKern:fix/proxy-host-enable-access-list
Open

Fix access list expansion when enabling proxy hosts#5711
CarminKern wants to merge 1 commit into
NginxProxyManager:developfrom
CarminKern:fix/proxy-host-enable-access-list

Conversation

@CarminKern

Copy link
Copy Markdown

Why

When a disabled Proxy Host is enabled again, the enable() code path only expands the access_list relation itself.

However, the nginx configuration template also requires the nested access_list.clients and access_list.items relations to generate the configured IP access rules and Basic Authentication entries.

Because these nested relations are missing, the regenerated nginx configuration does not contain the configured Access List rules after disabling and re-enabling the Proxy Host.

This change loads access_list.[clients,items] in the enable() path, matching the existing create and update code paths.

Tested by:

  • Creating a Proxy Host with an Access List
  • Verifying that the Access List is enforced
  • Disabling and re-enabling the Proxy Host
  • Verifying that the Access List is still enforced afterward
  • Building and running the modified Docker image on my server

Fixes #5710

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • API changes
  • Performance improvement
  • Test addition or update

AI Usage

  • AI was used to write this
  • AI was used to review this

@nginxproxymanagerci

Copy link
Copy Markdown

Docker Image for build 1 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5711

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access List is not enforced after disabling and re-enabling a Proxy Host

1 participant