Conversation
The box could open beyond the left edge of the games page and be cut off there, reading as though it had gone behind the side panel. Two things put it there, and neither was a z-index. It was portalled into the page rather than the body, and the page is `overflow: hidden`, so anything reaching past its edge was clipped away. Meanwhile the old overlay picked a side by comparing the tile against the midpoint of that page and then, for a left or right placement, never clamped horizontally — react-overlays only does that for top and bottom. An 800px box hung off a tile just right of centre therefore started at a negative offset, which the clip then hid. Narrowing the window took its width out of the page alone, since the spine and side panel don't shrink, so it took a small window to expose. Hosting it on the design-system popover answers both: Floating UI portals out of any clipping ancestor and shifts the panel back into view rather than letting it overhang. The reset that follows is that the page no longer has to hand its own element and bounds down through the grid and list to be measured, and the two components no longer nudge the overlay to reposition when the game info arrives — `GameInfoPopover`'s `onChange` exists only for a host that needs that, so it is now optional. `controls/OverlayTrigger` stays: it is exported from the extension API, so it is not ours to remove even with no callers left in tree.
insomnious
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The box could open beyond the left edge of the games page and be cut off there, reading as though it had gone behind the side panel.
Two things put it there, and neither was a z-index. It was portalled into the page rather than the body, and the page is
overflow: hidden, so anything reaching past its edge was clipped away. Meanwhile the old overlay picked a side by comparing the tile against the midpoint of that page and then, for a left or right placement, never clamped horizontally — react-overlays only does that for top and bottom. An 800px box hung off a tile just right of centre therefore started at a negative offset, which the clip then hid. Narrowing the window took its width out of the page alone, since the spine and side panel don't shrink, so it took a small window to expose.Hosting it on the design-system popover answers both: Floating UI portals out of any clipping ancestor and shifts the panel back into view rather than letting it overhang. The reset that follows is that the page no longer has to hand its own element and bounds down through the grid and list to be measured, and the two components no longer nudge the overlay to reposition when the game info arrives —
GameInfoPopover'sonChangeexists only for a host that needs that, so it is now optional.controls/OverlayTriggerstays: it is exported from the extension API, so it is not ours to remove even with no callers left in tree.