test: QA-103 manually set game location to manage a game - #23697
Merged
Conversation
Covers Games [#8.8]: unmanaged game listed, 'Game not discovered' dialog shown, manual folder selection accepted, game becomes active and listed as Managed, and a mod installs for it. Extracts the showOpenDialog stub into helpers/dialogs and adds Managed/Unmanaged section and dialog locators to the GamesPage POM. Store selection is skipped by the app itself under VORTEX_E2E, and no UAC prompt occurs for user-writable fake game dirs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RedRanger14
marked this pull request as ready for review
July 15, 2026 14:36
A failed probe build exited 0, so nx cached the empty result as
success and the app shipped without dotnetprobe - the renderer then
crashes at runtime ('Target crashed' in random e2e tests, seen on the
Linux runner). The build cache key also lacked the platform, letting
one OS's cached binary satisfy the other on shared caches.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The test steps run with continue-on-error, so a hard failure before Playwright starts (e.g. the app build aborting) was only visible as the encrypt step tripping over a missing test-results directory. Add an explicit check that fails with a pointer to the real log, and skip the encrypt/upload steps when there is nothing to archive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e config Machines with no configured NuGet sources (seen on a dev machine and suspected on the Linux CI runner) fail restore with NU1100 and shipped a probe-less build. A project-scoped nuget.config with an explicit nuget.org source removes the dependency on machine-level config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Marcin-NM
previously approved these changes
Jul 22, 2026
Aragas
reviewed
Jul 22, 2026
IDCs
reviewed
Jul 22, 2026
IDCs
requested changes
Jul 22, 2026
IDCs
left a comment
IDCs
left a comment
Contributor
There was a problem hiding this comment.
Functionally these changes are fine - but they're partially duplicated code and will be a maintenance nightmare going forward if we keep duplicating and diverging for each test we write.
…g the flow The 'Game not discovered' dialog assertions move into manageGame so the fixture path and the test share one implementation; the test keeps only its ticket-specific assertions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
IDCs
previously approved these changes
Jul 23, 2026
|
This PR has been marked as stale due to inactivity. |
|
This PR has conflicts. You need to rebase the PR before it can be merged. |
# Conflicts: # packages/e2e/src/selectors/games.ts
Master's games-page redesign replaced the bootstrap panels with CollapsibleSection headers and made the list windowed - section locators now anchor on the header buttons, and the QA-103 section assertions filter by name first. Mod URLs move to the shared constants file introduced on master. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This PR doesn't have conflicts anymore. It can be merged after all status checks have passed and it has been reviewed. |
Consolidates the remaining repeated patterns across specs: opening a game workspace via its spine button (game-management, mods-deploy) and opening the Mods page to verify a mod is listed (game-management, mods.spec, install helper). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
IDCs
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers Games [#8.8]: unmanaged game listed, 'Game not discovered' dialog shown, manual folder selection accepted, game becomes active and listed as Managed, and a mod installs for it. Extracts the showOpenDialog stub into helpers/dialogs and adds Managed/Unmanaged section and dialog locators to the GamesPage POM. https://linear.app/nexus-mods/issue/QA-103/games-88-manually-set-a-games-location-to-successfully-manage-it
Store selection is skipped by the app itself under VORTEX_E2E, and no UAC prompt occurs for user-writable fake game dirs.