Skip to content

DHCP ClientID may be generated from a transient all-zero Wi-Fi MAC address after a stand-by mode on Qi-Fi interface #734

Description

@KrisQdt

On Linux, dhcpcd we have sometimes an incorrect DHCP ClientID when a Wi-Fi interface temporarily reports an all-zero hardware address during initialization or reassociation.

Example log:

wlan0: using ClientID 01:00:00:00:00:00:00

The Wi-Fi adapter already had a valid MAC address at that time, but dhcpcd used an all-zero address to build the ClientID. As a result, the DHCP request is sent with an incorrect ClientID and the client may fail to obtain or renew its lease.

The log shows:

wlan0: carrier acquired
wlan0: using ClientID 01:00:00:00:00:00:00
wlan0: soliciting a DHCP lease

I think we should use a valid MAC address

Weshould wait for a valid hardware address or ignore transient invalid netlink notifications.

In if-linux.c, hardware-address changes were only processed when the interface was down:

if (!(ifi->ifi_flags & IFF_UP))

I have made the following patch
dhcpcd.patch

Is this patch correct ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions