Skip to content

Change: Redesign the gas plan bar chart - #209

Merged
Rolf-Smit merged 1 commit into
mainfrom
feature/redesign-gas-chart
Sep 8, 2026
Merged

Change: Redesign the gas plan bar chart#209
Rolf-Smit merged 1 commit into
mainfrom
feature/redesign-gas-chart

Conversation

@Rolf-Smit

Copy link
Copy Markdown
Contributor

This redesign comes with several improvements, mainly a color-semantics fix: emergency and bailout gas is no longer colored red by default, replaced with a lighter shade of blue, so a plan with enough gas does not indicate danger. Red and yellow are now only used when there actually isn't enough gas. The bar chart is now also more of a track, which is thinner and allows labels to be shown both below and above it. This means labels are no longer hidden if they are close enough for overlap to occur. Instead, they can always coexist.

This commit also removes the cylinders table from the gas plan, as it doesn't add much value, and adds the gas chart to images being shared.

This redesign comes with several improvements, mainly a color-semantics fix: emergency and bailout gas is no longer colored red by default, replaced with a lighter shade of blue, so a plan with enough gas does not indicate danger. Red and yellow are now only used when there actually isn't enough gas. The bar chart is now also more of a track, which is thinner and allows labels to be shown both below and above it. This means labels are no longer hidden if they are close enough for overlap to occur. Instead, they can always coexist.

This commit also removes the cylinders table from the gas plan, as it doesn't add much value, and adds the gas chart to images being shared.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.91983% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.76%. Comparing base (9ef7b03) to head (7aad314).

Files with missing lines Patch % Lines
...resentation/screens/planner/gasplan/GasBarChart.kt 92.00% 1 Missing and 13 partials ⚠️
...sner/presentation/component/graphs/LabeledTrack.kt 67.85% 0 Missing and 9 partials ⚠️
...ner/presentation/component/core/ColorExtensions.kt 37.50% 2 Missing and 3 partials ⚠️
...resentation/screens/planner/gasplan/GasPlanCard.kt 33.33% 0 Missing and 2 partials ⚠️
...pp/abysner/presentation/formatting/GasFormatter.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   64.49%   64.76%   +0.27%     
==========================================
  Files         144      144              
  Lines        8156     8009     -147     
  Branches     1852     1829      -23     
==========================================
- Hits         5260     5187      -73     
+ Misses       1799     1746      -53     
+ Partials     1097     1076      -21     
Flag Coverage Δ
domain 86.20% <ø> (ø)
presentation 59.46% <86.91%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolf-Smit
Rolf-Smit merged commit 42d6225 into main Sep 8, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
@Rolf-Smit
Rolf-Smit deleted the feature/redesign-gas-chart branch September 8, 2026 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants