Change: Redesign the gas plan bar chart - #209
Merged
Merged
Conversation
This redesign comes with several improvements, mainly a color-semantics fix: emergency and bailout gas is no longer colored red by default, replaced with a lighter shade of blue, so a plan with enough gas does not indicate danger. Red and yellow are now only used when there actually isn't enough gas. The bar chart is now also more of a track, which is thinner and allows labels to be shown both below and above it. This means labels are no longer hidden if they are close enough for overlap to occur. Instead, they can always coexist. This commit also removes the cylinders table from the gas plan, as it doesn't add much value, and adds the gas chart to images being shared.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 64.49% 64.76% +0.27%
==========================================
Files 144 144
Lines 8156 8009 -147
Branches 1852 1829 -23
==========================================
- Hits 5260 5187 -73
+ Misses 1799 1746 -53
+ Partials 1097 1076 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This redesign comes with several improvements, mainly a color-semantics fix: emergency and bailout gas is no longer colored red by default, replaced with a lighter shade of blue, so a plan with enough gas does not indicate danger. Red and yellow are now only used when there actually isn't enough gas. The bar chart is now also more of a track, which is thinner and allows labels to be shown both below and above it. This means labels are no longer hidden if they are close enough for overlap to occur. Instead, they can always coexist.
This commit also removes the cylinders table from the gas plan, as it doesn't add much value, and adds the gas chart to images being shared.