fix: correctness and dependency pass for 0.15.0 - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes seven bugs from an architecture review and clears the aiohttp advisories. One logical change per commit.
Breaking
requires-pythonis now>=3.10. Clearing all 34 Dependabot alerts needs aiohttp 3.14.3, and no release both fixes them and supports 3.9. The last 3.9-compatible release would have left 14 open, 1 high.lcwc.agencies.exceptionsremoved. Nothing ever raised those exceptions, but the import was legal before.AgencyResolver.get_unit_agencyremoved. It raisedAttributeErroron every call.Fixes
pyproject.toml, so a clean install thenimport lcwcraisedImportError. Also swaps thebs4placeholder forbeautifulsoup4.AgencyResolveraliased the module-level roster instead of copying it.AgencyResolver()as a default argument is evaluated once at import. Now aNonesentinel.UnitParsersets theout_of_countyandpendingflags instead.async with.utils/unitconverter.pydid not parse. Finished as a working abbreviation converter; not wired into the parsers yet.Verification
Built the wheel, installed it clean, and ran all three clients against the live service. Ran the README snippet verbatim. Each of the nine commits imports and parses, so the history bisects. Suite passes, flake8 and
black --checkclean.Confirmed
restadapter.py's deprecatedverify_ssl=still works in 3.14.3 before pinning. It should move tossl=before a release removes it.Supersedes #6.