feat(nvca): add grove and kai-scheduler Karta defns - #726
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR adds Karta configurations for DynamoGraphDeployment, PodCliqueSet, and Kai Scheduler PodGroup resources. The configurations map lifecycle states, discover child resources, define scaling and pod selectors, register supported kinds, and configure gang-scheduling groups. ChangesKarta resource mappings
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/compute-plane-services/nvca/internal/miniservice/karta/dynamo/nvidia.com_dynamographdeployment_v1beta1.yaml`:
- Around line 16-26: Add repository-native validation tests for both Dynamo
mappings: in
src/compute-plane-services/nvca/internal/miniservice/karta/dynamo/nvidia.com_dynamographdeployment_v1beta1.yaml:16-26,
cover initializing, running, and failed phases; in :49-75, cover child kinds and
normalized gang group keys; in
src/compute-plane-services/nvca/internal/miniservice/karta/dynamo/nvidia.com_dynamographdeployment_v1alpha1.yaml:21,
cover the initializing mapping; and in :52-78, cover child kinds and gang group
keys. Run the repository-native test runner before committing.
In
`@src/compute-plane-services/nvca/internal/miniservice/karta/grove/grove_io_podcliqueset_v1alpha1.yaml`:
- Around line 4-101: Add regression coverage for the Karta mapping defined by
the root component and child components clique and scalinggroup, validating
status mappings, resource discovery, scaling paths, pod selectors, and
gangScheduling configuration; if this repository has no applicable test
mechanism for YAML mappings, document that justification in the PR instead.
In
`@src/compute-plane-services/nvca/internal/miniservice/karta/kai-scheduler/scheduling-run-ai-podgroup-v2alpha2.yaml`:
- Around line 16-17: The scaleDefinition replicasPath mapping is incorrect for
hierarchical PodGroups because it reports scheduling thresholds as the current
replica count. Update the hierarchical PodGroup configuration to use a
Karta-compatible replica-count mapping, or remove scale reporting for this
unsupported mode; preserve the existing flat PodGroup behavior and add
regression coverage for both modes, or document why tests are not applicable.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 68e96a02-17ec-4601-9f44-7e9740733e73
📒 Files selected for processing (4)
src/compute-plane-services/nvca/internal/miniservice/karta/dynamo/nvidia.com_dynamographdeployment_v1alpha1.yamlsrc/compute-plane-services/nvca/internal/miniservice/karta/dynamo/nvidia.com_dynamographdeployment_v1beta1.yamlsrc/compute-plane-services/nvca/internal/miniservice/karta/grove/grove_io_podcliqueset_v1alpha1.yamlsrc/compute-plane-services/nvca/internal/miniservice/karta/kai-scheduler/scheduling-run-ai-podgroup-v2alpha2.yaml
a0add2c to
e7505c6
Compare
Signed-off-by: Eric Stroczynski <estroczynski@nvidia.com>
e7505c6 to
44e5f12
Compare
TL;DR
Add new Dynamo DGD version, Grove
PodCliqueSet, and KAI SchedulerPodGroupKarta types to miniservice controller as follow-up to #603Additional Details (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
For the Reviewer
For QA (optional for docs, build, test, refactor, ci, chore, style, and revert PRs)
Issues
Relates to #598
Checklist
Summary by CodeRabbit