dpf: Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05) - #4774
Conversation
Summary by CodeRabbit
WalkthroughChangesDPF configuration updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/dpf/src/flavor.rs (1)
493-509: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd regression coverage for deployment-specific configuration content.
The new branch changes
/etc/mellanox/mlnx-bf.conf, but the providedconfig_file_count_depends_on_proxytest checks only the file count. Add assertions for bothdefault_flavor(BF3) andflavor_bf4(BF4 generic). Verify that BF3 omitsSNAP_DMA_SF="no"and BF4 generic includes it while retaining the shared settings.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/dpf/src/flavor.rs` around lines 493 - 509, Add regression assertions in the config_file_count_depends_on_proxy test for both default_flavor (BF3) and flavor_bf4 (BF4 generic), inspecting /etc/mellanox/mlnx-bf.conf content. Verify BF3 retains the shared settings but omits SNAP_DMA_SF="no", while BF4 generic retains the shared settings and includes that setting.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/dpf/src/flavor.rs`:
- Around line 493-509: Add regression assertions in the
config_file_count_depends_on_proxy test for both default_flavor (BF3) and
flavor_bf4 (BF4 generic), inspecting /etc/mellanox/mlnx-bf.conf content. Verify
BF3 retains the shared settings but omits SNAP_DMA_SF="no", while BF4 generic
retains the shared settings and includes that setting.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5bb2b7e4-998b-4b0a-afbb-eb36ed7a878f
⛔ Files ignored due to path filters (5)
crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_bluefieldsoftwares.provisioning.dpu.nvidia.com.yamlis excluded by!crates/dpf/crds/**crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpudeployments.svc.dpu.nvidia.com.yamlis excluded by!crates/dpf/crds/**crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpunodemaintenances.provisioning.dpu.nvidia.com.yamlis excluded by!crates/dpf/crds/**crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpus.provisioning.dpu.nvidia.com.yamlis excluded by!crates/dpf/crds/**crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpusets.provisioning.dpu.nvidia.com.yamlis excluded by!crates/dpf/crds/**
📒 Files selected for processing (2)
crates/dpf/Makefile.tomlcrates/dpf/src/flavor.rs
…05) (NVIDIA#4774) Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05) ## Related issues ## Type of Change - [ ] **Add** - New feature or capability - [x] **Change** - Changes in existing functionality - [ ] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes - [ ] **This PR contains breaking changes** ## Testing - [ ] Unit tests added/updated - [ ] Integration tests added/updated - [x] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes
Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05)
Related issues
Type of Change
Breaking Changes
Testing
Additional Notes