Skip to content

dpf: Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05) - #4774

Merged
abvarshney-nv merged 1 commit into
NVIDIA:mainfrom
abvarshney-nv:dpf_sync_0748a9f91880d06fa0c8147f9af733ac9960535f
Aug 11, 2026
Merged

dpf: Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05)#4774
abvarshney-nv merged 1 commit into
NVIDIA:mainfrom
abvarshney-nv:dpf_sync_0748a9f91880d06fa0c8147f9af733ac9960535f

Conversation

@abvarshney-nv

Copy link
Copy Markdown
Contributor

Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05)

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@abvarshney-nv
abvarshney-nv requested a review from a team as a code owner August 10, 2026 17:07
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Summary by CodeRabbit

  • Bug Fixes
    • Improved configuration generation for generic BF3 and BF4 deployments.
    • BF4 configurations now correctly disable SNAP DMA SF, while BF3 configurations retain their existing settings.
    • Updated the underlying platform revision to improve compatibility and reliability.

Walkthrough

Changes

DPF configuration updates

Layer / File(s) Summary
Deployment-specific BF configuration
crates/dpf/src/flavor.rs
BF3 and BF4 generic flavor builders pass deployment types to get_config_files. The function builds shared mlnx-bf.conf settings and adds SNAP_DMA_SF="no" for BF4 generic deployments.
DOCA revision update
crates/dpf/Makefile.toml
The pinned DOCA repository commit changes to a newer revision.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly states that the NICO Rust binding is synchronized to the specified DPF nightly version.
Title check ✅ Passed The title clearly identifies the DPF binding synchronization and specifies the target DPF version and date.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
crates/dpf/src/flavor.rs (1)

493-509: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add regression coverage for deployment-specific configuration content.

The new branch changes /etc/mellanox/mlnx-bf.conf, but the provided config_file_count_depends_on_proxy test checks only the file count. Add assertions for both default_flavor (BF3) and flavor_bf4 (BF4 generic). Verify that BF3 omits SNAP_DMA_SF="no" and BF4 generic includes it while retaining the shared settings.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/dpf/src/flavor.rs` around lines 493 - 509, Add regression assertions
in the config_file_count_depends_on_proxy test for both default_flavor (BF3) and
flavor_bf4 (BF4 generic), inspecting /etc/mellanox/mlnx-bf.conf content. Verify
BF3 retains the shared settings but omits SNAP_DMA_SF="no", while BF4 generic
retains the shared settings and includes that setting.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/dpf/src/flavor.rs`:
- Around line 493-509: Add regression assertions in the
config_file_count_depends_on_proxy test for both default_flavor (BF3) and
flavor_bf4 (BF4 generic), inspecting /etc/mellanox/mlnx-bf.conf content. Verify
BF3 retains the shared settings but omits SNAP_DMA_SF="no", while BF4 generic
retains the shared settings and includes that setting.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5bb2b7e4-998b-4b0a-afbb-eb36ed7a878f

📥 Commits

Reviewing files that changed from the base of the PR and between 0427550 and 2bceea8.

⛔ Files ignored due to path filters (5)
  • crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_bluefieldsoftwares.provisioning.dpu.nvidia.com.yaml is excluded by !crates/dpf/crds/**
  • crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpudeployments.svc.dpu.nvidia.com.yaml is excluded by !crates/dpf/crds/**
  • crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpunodemaintenances.provisioning.dpu.nvidia.com.yaml is excluded by !crates/dpf/crds/**
  • crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpus.provisioning.dpu.nvidia.com.yaml is excluded by !crates/dpf/crds/**
  • crates/dpf/crds/apiextensions.k8s.io_v1_customresourcedefinition_dpusets.provisioning.dpu.nvidia.com.yaml is excluded by !crates/dpf/crds/**
📒 Files selected for processing (2)
  • crates/dpf/Makefile.toml
  • crates/dpf/src/flavor.rs

@abvarshney-nv
abvarshney-nv merged commit 24cf0f8 into NVIDIA:main Aug 11, 2026
65 checks passed
@abvarshney-nv
abvarshney-nv deleted the dpf_sync_0748a9f91880d06fa0c8147f9af733ac9960535f branch August 11, 2026 09:47
Sinck pushed a commit to Sinck/infra-controller that referenced this pull request Aug 11, 2026
…05) (NVIDIA#4774)

Sync NICO rust binding to DPF v26.8.0-a02ded2e-nightly (2026-08-05)

## Related issues

## Type of Change
- [ ] **Add** - New feature or capability
- [x] **Change** - Changes in existing functionality
- [ ] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes
- [ ] **This PR contains breaking changes**

## Testing
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [x] Manual testing performed
- [ ] No testing required (docs, internal refactor, etc.)

## Additional Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants