fix(bmc-explorer): tolerate invalid BlueField system interface MACs

[williampnvidia]

Some pre-ingestion BlueField-3 BMC firmware reports non-48-bit values in the
MACAddress field of enabled ComputerSystem eth0 and eth1 interfaces.

The nv-redfish explorer currently fails the entire endpoint exploration when
it encounters one of these values. This prevents host/DPU pairing and blocks
ingestion before the normal DPU BMC and NIC firmware update can run.

This change treats an invalid MAC as absent only for BlueField ComputerSystem
interfaces. It preserves the interface and continues processing valid OOB
interfaces, the OEM BaseMAC, pairing serial number, DPU mode, and firmware
inventory.

Manager interfaces and non-BlueField ComputerSystem interfaces remain strict.

A regression test reproduces the failure using an enabled, link-down BF3
eth0 with a sanitized 20-octet MAC value. It verifies that:

• Exploration succeeds.
• The invalid eth0 is retained without a MAC.
• The valid OOB MAC is retained.
• The OEM BaseMAC and DPU pairing serial remain available.

Related issues

Fixes #4756

Related historical changes:

• feat: site explorer with nv-redfish #465
• fix: bmc-explorer: Bluefield: do not require system eth interfaces #516

Type of Change

• Add - New feature or capability
• Change - Changes in existing functionality
• Fix - Bug fixes
• Remove - Removed features or deprecated functionality
• Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

• This PR contains breaking changes

Testing

• Unit tests added/updated
• Integration tests added/updated
• Manual testing performed
• No testing required (docs, internal refactor, etc.)

Passed locally:

cargo fmt --all -- --check
cargo test -p bmc-explorer
cargo clippy -p bmc-explorer --all-targets -- -D warnings
git diff --check

Results:

• 7 unit tests passed.
• 26 integration tests passed.
• Crate-level Clippy passed with warnings denied.
• Formatting and diff checks passed.

The repository-wide check was attempted with:

cargo make --no-workspace clippy-flow

It cannot complete on the current macOS host because libudev-sys requires
pkg-config and the Linux libudev development package. This PR remains a
draft until the same command passes on Linux.

Additional Notes

The change is intentionally limited to MAC conversion for BlueField
ComputerSystem interfaces. It does not change manager-interface handling,
non-BlueField behavior, Site Explorer configuration, or firmware policy.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 22084b33-c979-42a8-a532-a842720c8bdf

📥 Commits

Reviewing files that changed from the base of the PR and between b0439c2 and 735500a.

📒 Files selected for processing (2)

• crates/bmc-explorer/src/computer_system.rs
• crates/bmc-explorer/tests/integration/bluefield3_explore.rs

---

Summary by CodeRabbit

• Bug Fixes

  • Improved BlueField system detection and OOB interface selection.
  • Invalid Ethernet MAC addresses are now ignored without disrupting system exploration.
  • Disabled interfaces continue to be excluded from processing.

• Tests

  • Added coverage confirming exploration succeeds with invalid interface MAC data while preserving valid OOB, DPU, and pairing information.

Walkthrough

BlueField exploration now treats invalid system-interface MAC addresses as absent while retaining the interface. OOB fallback selection uses the detected BlueField type. An integration test verifies successful exploration and preservation of valid report data.

Changes

BlueField MAC handling

Layer / File(s)	Summary
Handle invalid BlueField MACs crates/bmc-explorer/src/computer_system.rs	The explorer detects BlueField systems once. It retains BlueField interfaces with invalid MAC addresses and applies the BlueField flag to OOB fallback selection.
Validate exploration results crates/bmc-explorer/tests/integration/bluefield3_explore.rs	The integration test injects an invalid eth0 MAC and verifies that exploration succeeds while OOB, DPU base MAC, and pairing serial data remain available.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• NVIDIA/infra-controller#4534: Extends related BlueField Ethernet MAC validation and OOB fallback logic.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the fix for invalid BlueField system interface MAC addresses.
Description check	✅ Passed	The description explains the BlueField MAC parsing failure, intended behavior, scope, and regression testing.
Linked Issues check	✅ Passed	The changes address issue #4756 by tolerating invalid BlueField system MACs while preserving interfaces and exploration data.
Out of Scope Changes check	✅ Passed	The changes remain limited to BlueField MAC handling and its integration regression test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}