Skip to content

chore(ci): update notice files - #469

Merged
coryrylan merged 2 commits into
mainfrom
topic-example-fix
Oct 27, 2026
Merged

coryrylan merged 2 commits into
mainfrom
topic-example-fix

Conversation

@coryrylan

@coryrylan coryrylan commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features
    • Added a canvas editor example with an outline tree, workflow nodes, and connecting paths. The example includes gridlines, a minimap, pan and zoom controls, reset and fit options, and navigation guidance. It also displays the node count, giving users a ready-to-explore example of an interactive workflow canvas.

@coryrylan coryrylan self-assigned this Oct 27, 2026
@coryrylan coryrylan changed the title Topic example fix chore(ci): update notice files Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7bfc187 and b128a18.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0a3974e and 7bfc187.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 6
  • NOTICE.md
  • projects/cli/NOTICE.md
  • projects/internals/patterns/package.json
  • projects/internals/patterns/src/templates.examples.ts
  • projects/lint/NOTICE.md
  • projects/pi/NOTICE.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

Walkthrough

The patterns package adds viewport build inputs and a CanvasEditor template with five workflow nodes and viewport controls. NOTICE files update listed versions of ESLint and related packages.

Changes: Canvas editor example

Layer / File(s) Summary
Viewport build and type-check inputs
projects/internals/patterns/package.json
Adds the viewport workspace dependency, build and declaration inputs, and viewport build dependencies for build and type checking.
Canvas editor template
projects/internals/patterns/src/templates.examples.ts
Registers viewport components and adds a canvas editor example with a five-node workflow, gridlines, a minimap, zoom controls, and navigation guidance.

NOTICE version updates

Layer / File(s) Summary
Bundled software and license records
NOTICE.md, projects/cli/NOTICE.md, projects/lint/NOTICE.md, projects/pi/NOTICE.md
Updates listed versions of @eslint/css, @html-eslint/eslint-plugin, @html-eslint/parser, and eslint. Copyright attributions remain unchanged.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested labels: type(feat)

Merge Risk: Minimal · previous review 7bfc1

The canvas controls are wired to the intended viewport, and no issue requiring correction before merge is established.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the NOTICE.md version updates, which are a significant part of the changes. It does not mention the added viewport build configuration or CanvasEditor template, but the …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title accurately describes the NOTICE.md version updates, which are a significant part of the changes. It does not mention the added viewport build configuration or CanvasEditor template, but the title remains related and sufficiently clear.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

main 6972e4b topic-example-fix b128a18 +/-
99% 99% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 27, 2026 22:11 UTC

Signed-off-by: Cory Rylan <crylan@nvidia.com>
Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan
coryrylan enabled auto-merge (rebase) October 27, 2026 22:00
@coryrylan
coryrylan merged commit 3a27e11 into main Oct 27, 2026
17 checks passed
@coryrylan
coryrylan deleted the topic-example-fix branch October 27, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants