Repository navigation
chore(viewport): cover unsupported zoom range keys - #416
Merged
Merged
Conversation
Verifies unrelated keys do not change an explicitly stepped zoom range, raising line coverage to 100% and branch coverage to 92.59%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cory Rylan <coryrylan@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
Coverage task selected because: “1 uncovered lines, 98.21% lines and 87.03% branches, the smallest gap below the 90% threshold.”
Measurement
No public API changed. This only verifies that an unrelated key leaves an explicitly stepped zoom range unchanged. Remaining defensive branches and production code were deliberately left alone.
Validation: viewport lint, unit, types, axe, SSR, Lighthouse, visual, and final repository-wide CI all pass.