Copy the imaginary halves of the inputs in MmaPlanarComplex - #3575
Open
darkdi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reading
mma_planar_complex.hand stopped onfrag_A.imag = frag_A.imag;in the non-conjugate branch. Grepping the rest of the file,A_in.imagandB_in.imagdo not appear anywhere, so the imaginary halves of both input fragments never reach the local ones.ArrayPlanarComplexholds two plaincutlass::Arraymembers and nothing clears them, sofrag_A.imagis whatever was on the stack, and the conjugate branch negates that same uninitialized value rather than the input. Three of the four real-valued mmas below then consume it.I have not run this on hardware and could not find a test that reaches this specialization, so it is worth a second opinion on whether it is still on a live path before this goes in.