[libcudf] Add memory_resources support for gather - #23690
Draft
nirandaperera wants to merge 12 commits into
Draft
Conversation
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Route gather, list/segmented gather, and sizes-to-offsets through explicit output/temporary resources. Enable fail_on_current around non-list gather tests; leave list and slice-dependent cases with TODOs for transitive ports.
Avoid ambiguous empty fixed_width/list wrappers with stream/mr args, drop fail_on_current around struct gather blocked by slice/get_sliced_child, and use DONT_CHECK for in-bounds sliced struct gather so nullability matches.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
17 tasks
bdice
changed the title
memory_resources suppor for gathermemory_resources support for gather
nirandaperera
changed the title
memory_resources support for gathermemory_resources support for gather
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #23665 #23688
A part of #20780.
gather, list/segmented gather, and sizes-to-offsets helpers to takecudf::memory_resources, routing output and temporary allocations explicitly.memory_resources; wrap non-list gather calls in scopedfail_on_current_device_resource_use()where safe.valid_if,slice/get_sliced_child,concatenate, nested list-wrapper construction).Test plan
COPYING_TEST --gtest_filter='Gather*:SegmentedGather*:StructGather*:TypedStructGather*'Checklist