fix(breakfix): require retirement notice evidence - #593
Draft
osu wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Hasan Khan <hasank@nvidia.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Member
Author
|
/ok to test 661f442 |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-08-21 18:44:22 UTC | Commit: 661f442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens BFX02-02 so a generic lifecycle record cannot be treated as retirement-notice evidence.
A PASS now requires:
Generic scheduled, CLOSED, DOWN, drained, maintenance, self-reported, and event-issued-time-only records do not pass.
Live GB300 validation
Read-only validation on Mississippi confirmed that BCM and Slurm are queryable, but no authoritative retirement notice is currently present:
The live result is SKIP/unproven, not PASS. This PR prevents a false positive and does not close the requirement until a real provider-issued retirement notice can be observed.
Tests
Part of #212