Skip to content

fix(breakfix): require retirement notice evidence - #593

Draft
osu wants to merge 1 commit into
NVIDIA:mainfrom
osu:issue-212-gb300-direct
Draft

fix(breakfix): require retirement notice evidence#593
osu wants to merge 1 commit into
NVIDIA:mainfrom
osu:issue-212-gb300-direct

Conversation

@osu

@osu osu commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

Hardens BFX02-02 so a generic lifecycle record cannot be treated as retirement-notice evidence.

A PASS now requires:

  • provider-origin evidence
  • an explicit instance, machine, node, or rack target
  • a retirement-specific notice type
  • a timezone-aware scheduled retirement timestamp

Generic scheduled, CLOSED, DOWN, drained, maintenance, self-reported, and event-issued-time-only records do not pass.

Live GB300 validation

Read-only validation on Mississippi confirmed that BCM and Slurm are queryable, but no authoritative retirement notice is currently present:

  • BCM event query succeeded with zero retirement or decommission notices
  • persisted BCM events contained zero retirement or decommission matches
  • 144 Slurm node records contained zero retirement or decommission matches

The live result is SKIP/unproven, not PASS. This PR prevents a false positive and does not close the requirement until a real provider-issued retirement notice can be observed.

Tests

  • 42 focused break-fix tests passed
  • make test and make demo-test passed
  • suite wiring, Ruff, formatting, and pre-commit passed

Part of #212

Signed-off-by: Hasan Khan <hasank@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dd6433bb-b8a4-43e4-9164-6f3487ed321c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@osu

osu commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/ok to test 661f442

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-08-21 18:44:22 UTC | Commit: 661f442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant