[https://nvbugs/6720250][test] Waive test_openai_completion_list_prompt_stream_reuses_stream_metadata - #18706
Conversation
…pt_stream_reuses_stream_metadata The test builds its server with object.__new__(OpenAIServer), bypassing __init__, and hand-sets only the attributes the code path needed when it was written. PR NVIDIA#17491 moved the openai_completion streaming path from the module-level get_steady_clock_now_in_seconds() to self._adjusted_steady_clock.now(), so the stub now raises AttributeError. Waived under the same NVBug as the VisualGen timing breakage, which has the same root cause. This is a stopgap; the fix is proposed on PR NVIDIA#18686. Signed-off-by: Yiyun Lu <55233584+luyiyun1021@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe integration waiver list now skips the OpenAI completion list-prompt streaming metadata reuse test and references NVBUG 6720250. ChangesTest waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change temporarily skips the failing OpenAI streaming metadata test and does not modify product or test implementation code. The waiver entry is valid and scoped to the intended test, so it is ready to merge. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
unittest/llmapi/test_llm.py::test_openai_completion_list_prompt_stream_reuses_stream_metadatahas been failing onA100X-PyTorch-Post-Merge-1since the clock refactor in #17491 landed, and is currently unwaived.The test builds its server with
object.__new__(OpenAIServer), bypassing__init__, and hand-sets only the attributes the code path needed when it was written. #17491 changed theopenai_completionstreaming path (generator_wrapper) from the module-levelget_steady_clock_now_in_seconds()toself._adjusted_steady_clock.now(), so the hand-built stub is now missing an attribute it previously never had to set.Waived under NVBug 6720250 because it shares its root cause with the VisualGen timing breakage tracked there: #17491 rewrote every clock call site present in its own tree, and the sites it did not see are what broke. Regression window confirmed against post-merge builds —
L0_PostMerge #2946(30316da103a0) green,#2947(53bb31fdcf8b) red, and #17491 is in that range.Follow-up required
This is a stopgap. The real fix is two lines and is proposed on #18686 (#18686 (comment)):
This waiver must be removed when that fix lands, otherwise closing NVBug 6720250 would leave an orphan waiver masking a test that is green again. This exact test has gone stale the same way twice before — #16841 (NVBug 6507081) added
reasoning_parser = None, #17401 (NVBug 6555875) swappedperf_metricsfor_collect_perf_metrics— and both times the fake was refreshed and the waiver deleted in the same PR.Test Coverage
Waiver-only change; no product or test code is touched.
The failure and the proposed fix were both reproduced on a local build of main at
98c176f042(B200,--cuda_architectures 100-real): the test fails with theAttributeErrorabove, still fails with #18686 applied (same error, shifted to line 2509 by the SPDX header that PR adds), and passes once the two lines above are added.PR Checklist
Dev Engineer Review
tests/integration/test_lists/waives.txt.unittest/llmapi/test_llm.py::test_openai_completion_list_prompt_stream_reuses_stream_metadata.6720250.#18686lands.QA Engineer Review
tests/integration/test_lists/waives.txt.