[None][docs] fix legacy benchmark KV cache config - #18671
Conversation
Nest the documented cache dtype under the runtime key so benchmark configuration no longer silently falls back to auto. Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe benchmarking documentation replaces the legacy ChangesQuantization documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The benchmark documentation now shows the KV-cache dtype in the configuration structure consumed by the runtime, preventing the example from silently defaulting to auto. The change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the issue, the parser behavior, the documentation change, and the validation performed. It does not include the PR checklist section, but the core required information is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
kv_cache_configkv_cache_config.dtypefield in the adjacent tipWhy
tensorrt_llm/bench/benchmark/utils/general.pyreads the YAML throughllm_args_dict.get(\"kv_cache_config\", {\"dtype\": \"auto\"})and then readsdtypefrom that mapping. The documented top-levelkv_cache_dtypeis therefore ignored and the benchmark falls back toauto.Test plan
{\"kv_cache_dtype\": \"fp8\"}resolves toauto, while{\"kv_cache_config\": {\"dtype\": \"fp8\"}}resolves tofp8git diff --checkSigned-off-by: ADou ikun3.1415927@gmail.com
Dev Engineer Review
kv_cache_config.dtype.auto,fp8, andnvfp4.auto.QA Engineer Review
No test changes.