[None][test] Remove deprecated test_cli_flow.py and unused Llama-3.1… - #18654
Draft
xinhe-nv wants to merge 3 commits into
Draft
[None][test] Remove deprecated test_cli_flow.py and unused Llama-3.1…#18654xinhe-nv wants to merge 3 commits into
xinhe-nv wants to merge 3 commits into
Conversation
…-8B accuracy tests test_cli_flow.py and its CliFlowAccuracyTestHarness base are unreferenced in any test list. Also drop two Llama-3.1-8B-Instruct accuracy tests (test_suffix_automaton, test_guided_decoding_with_eagle3_low_latency_dispatch) that are not present in any test list. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
…sses TestLlama3_1_8B and TestLlama3_1_8B_Instruct_Eagle3 in test_llm_api_autodeploy.py have no test methods referenced by any test list, so drop both classes entirely. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
…n and unit tests Fully removes Llama-3.1-8B / Llama-3.1-8B-Instruct from the test suite, including dedicated accuracy test classes, shared multi-model parametrizations in test_e2e.py/disaggregated/examples/llmapi tests, corresponding test-list entries (waives.txt, qa/*, test-db/*), accuracy reference YAMLs, the RocketKV sparse-attention unit test, spec-decoding and AutoDeploy smoke tests, and the Llama architecture unit test (test_modeling_llama.py, with its shared Scenario/reduce_llama_config helpers preserved for test_modeling_mllama.py). Files left with no remaining tests were deleted outright. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-8B accuracy tests
test_cli_flow.py and its CliFlowAccuracyTestHarness base are unreferenced in any test list. Also drop two Llama-3.1-8B-Instruct accuracy tests (test_suffix_automaton, test_guided_decoding_with_eagle3_low_latency_dispatch) that are not present in any test list.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.