fix(async): handle nested event loops in asyncio.run calls#117
Open
zhenliemao wants to merge 1 commit into
Open
fix(async): handle nested event loops in asyncio.run calls#117zhenliemao wants to merge 1 commit into
zhenliemao wants to merge 1 commit into
Conversation
This fix allows SkillSpector to run in environments that already have a running event loop, such as: - Jupyter Notebooks - LangGraph Studio - FastAPI applications - Any programmatic usage within async code The fix detects if there's already a running loop and uses run_until_complete() instead of throwing a RuntimeError. This prevents silent fallback to unfiltered static findings. Fixes NVIDIA#108 Signed-off-by: GitHub User <494822673@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix allows SkillSpector to run in environments that already have a running event loop, preventing RuntimeError when asyncio.run() is called from within an existing loop.
Problem
When running SkillSpector in environments like:
The call to asyncio.run() throws a
RuntimeError: This event loop is already runningand falls back to unfiltered static findings, silently disabling LLM analysis.Solution
Added detection for running event loops:
loop.run_until_complete()to execute the async taskasyncio.run()This maintains backward compatibility while supporting nested loop environments.
Testing
Impact
Fixes #108
Checklist