Conversation
Potential Concerns
|
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
97fddfc to
207dcb6
Compare
|
Addressed all three review points and rebased onto current
Validation: pre-commit, full |
|
🌿 Preview your docs: https://nvidia-preview-pr-3439.docs.buildwithfern.com/openshell |
There was a problem hiding this comment.
@johntmyers do you mind taking a look at this change and making sure it looks ok?
Summary
Add create-time sandbox service exposure across the gateway API, CLI, and maintained SDKs, returning routed service URLs keyed by service name. Include a Codex app-server example that uses gateway-managed credential refresh and connects a local Codex client through the exposed WebSocket endpoint.
Related Issue
Closes #3402
Changes
openshell sandbox create --expose PORT, structured URL output, validation, and rollback when endpoint persistence failsexamples/codex-app-serverimage, launcher, and local-client workflowTesting
mise run pre-commitpassesAdditional focused tests:
cargo test -p openshell-server create_sandbox_begins_rollback_when_service_exposure_failscargo test -p openshell-server create_sandbox_registers_requested_service_exposurescargo test -p openshell-cli --test sandbox_create_lifecycle_integration sandbox_create_json_stdout_is_parseablecargo test -p openshell-cli service_url_for_gateway_uses_external_gateway_portChecklist