Skip to content

refactor(dev): share gateway launcher plumbing - #3432

Open
drew wants to merge 9 commits into
codex/fix-rfc0012-release-canaryfrom
codex/gateway-launcher-cleanup
Open

drew wants to merge 9 commits into
codex/fix-rfc0012-release-canaryfrom
codex/gateway-launcher-cleanup

Conversation

@drew

@drew drew commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Simplify the local gateway launch scripts without changing driver ownership. The common script now contains only shared shell plumbing, while each compute driver keeps its own configuration and runtime setup.

Related Issue

No issue required: this is a mechanical cleanup of the local developer launchers, split from #3365 to keep that fix focused.

Changes

  • Add shared helpers for port checks, gateway registration, OTLP detection, and local container-image builds.
  • Move Kubernetes gateway setup into gateway-kubernetes.sh.
  • Keep gateway.sh as a driver detector and dispatcher.
  • Keep Docker, Podman, Kubernetes, and VM TOML generation in their driver-specific scripts.
  • Add a direct gateway:kubernetes mise task.
  • Isolate gateway metadata written by the generated-config test.

Testing

  • bash tasks/scripts/test-gateway-config.sh
  • bash tasks/scripts/test-gateway-pull-policy.sh
  • bash -n for all changed gateway scripts
  • Docker launcher smoke test: gateway start, sandbox create, exec, and delete
  • mise run pre-commit

Checklist

  • Follows Conventional Commits
  • Commit is signed off (DCO)

@drew
drew added this pull request to stack #3433 September 17, 2026 21:34
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Run Docker supervisors on host networking so they use the operator-configured primary gateway endpoint. Remove the unused compute-driver callback listener negotiation and listener-scoped routing machinery.

BREAKING CHANGE: The ComputeDriver API no longer exposes GetGatewayListenerRequirements or GatewayListenerRequirement. External drivers must regenerate bindings and connect supervisors to the configured primary gateway endpoint.

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
@drew
drew force-pushed the codex/gateway-launcher-cleanup branch from ba26c78 to 42dc47f Compare September 17, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant