Conversation
gmenher
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 16, 2026 15:02
Collaborator
|
/ok to test c5afa06 |
gmenher
force-pushed
the
openshell/helm-gateway-config
branch
from
September 18, 2026 11:50
c5afa06 to
cb8ae8b
Compare
|
Label |
Collaborator
|
/ok to test cb8ae8b |
krishicks
previously approved these changes
Sep 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 18, 2026
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
Signed-off-by: Gaizka Menendez Hernandez <gmenende@redhat.com>
gmenher
force-pushed
the
openshell/helm-gateway-config
branch
from
September 18, 2026 16:48
cb8ae8b to
5efe3e8
Compare
Contributor
Author
|
@krishicks I pushed a new commit solving a conflict with |
Collaborator
|
/ok to test 5efe3e8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the Helm chart's field-by-field
gateway.tomlgeneration with a generic, schema-v2gatewayConfigboundary. Remove the legacy mirrored application configuration contract, preserve a non-secret ConfigMap boundary and Helm-owned Secret wiring, and derive dual-use runtime settings from their Kubernetes packaging owners so rendered resources and gateway configuration remain coherent.Related Issue
Closes #3060.
Changes
gatewayConfigdefault and a deterministic generic YAML-to-TOML renderer.gatewayConfigto non-secret values; retain Secret, environment, file, and volume wiring for credentials and private material.Testing
mise run helm:test(153 chart tests and 4 workspace tests)mise run helm:lintacross chart overlaysmise exec -- skaffold diagnosebash e2e/parity/kubernetes-options-test.shRUST_TEST_THREADS=1 OPENSHELL_E2E_KUBE_TEST=host_gateway_alias mise run e2e:kubernetesThe full concurrent Kubernetes E2E suite also exposed an upstream RFC 0012 stopped-sandbox lifecycle failure outside this PR's diff; the focused configuration migration E2E passes.
Checklist
Signed-off-bytrailers.