fix(ci): upstream Windows SDK validation support - #3327
Conversation
Port remaining Windows validation tooling from GitLab independently of the combined MXC runtime port. Preserve locked SDK dependencies and guard temporary launcher cleanup. Co-authored-by: Shailendra Singh <shailendras@nvidia.com> Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
This is a project-valid, concentrated Windows validation/tooling change. The initial review found one blocking ARM64 dependency-installation issue; the remaining changes have no additional blocking findings.
Action required: @prekshivyas, make the TypeScript install architecture-aware and complete all pinned native dependency setup before parallel validation tasks begin.
Blocking findings:
GATOR-3f4a651f-01: Native ARM64 TypeScript CI receives an x64-only dependency tree and later mutates it during parallel validation.
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Concentrated Windows SDK/build-validation support with a clear motivation and test path; related to #2050 and distinct from the superseded runtime port in #3326.
- Docs: Fern docs are not needed because this changes contributor validation tooling rather than direct user-facing behavior; relevant testing and architecture documentation is updated.
- Checks: Current-head Branch Checks, Helm Lint, Trivy Changes, and DCO are green.
- E2E: N/A for this validation-tooling-only change.
- Head SHA:
3f4a651fc1ace0c7e89f5eeff737f4ada58078fb - Base SHA:
cc780d4e17512e8f804f68c153c033fe6584ae3a - Merge base SHA:
cc780d4e17512e8f804f68c153c033fe6584ae3a - Patch ID:
079e94b0410e8593b1b0fb0ddc0ceaae803ddc4b - Gator payload:
8 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
|
Label |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
drew
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Thanks @prekshivyas. I checked the architecture-aware TypeScript installation update against the prior ARM64 finding: all pinned native dependencies are now installed and verified before validation tasks run, and the later node_modules mutation has been removed. No blocking findings remain.
Blocking findings:
- No blocking findings remain
Carried findings:
- None;
GATOR-3f4a651f-01is resolved by this head
Gator metadata
- Validation: Concentrated Windows validation/tooling work related to #2050 and the maintainer-requested upstreaming effort in #3326.
- Docs: Fern docs are not needed because this is contributor validation tooling; the relevant testing and architecture documentation is updated.
- Checks: Required Branch Checks and E2E are running for the current head; Helm Lint, Trivy Changes, DCO, and GPU E2E are green.
- E2E:
test:e2eis applied and the current-head E2E workflow is queued/running. - Head SHA:
42ccd430c5f899a42d8536778e16b5f43527d339 - Base SHA:
cc780d4e17512e8f804f68c153c033fe6584ae3a - Merge base SHA:
cc780d4e17512e8f804f68c153c033fe6584ae3a - Patch ID:
f17aa7e884c4d609c46e727c767ac4e562e3005e - Gator payload:
8 - Review mode:
follow_up - Previous reviewed SHA:
3f4a651fc1ace0c7e89f5eeff737f4ada58078fb - Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
* fix(ci): upstream Windows SDK validation support Port remaining Windows validation tooling from GitLab independently of the combined MXC runtime port. Preserve locked SDK dependencies and guard temporary launcher cleanup. Co-authored-by: Shailendra Singh <shailendras@nvidia.com> Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> * fix(ci): install native TypeScript dependencies before validation Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> --------- Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com> Co-authored-by: Shailendra Singh <shailendras@nvidia.com>
Summary
Upstream the remaining Windows validation tooling found during the GitLab-to-GitHub comparison for #3326. This is a separate, main-based sweep: it does not duplicate the combined !98/!105/!108 runtime port or the work in #3163, #3221, and #3296.
Draft: native pre-commit and SDK unit tests pass, but broader Go code-generation and gateway parity checks still fail as detailed below. This is not physical MXC or NemoClaw qualification evidence.
Related Issue
Related to #2050 and the maintainer-requested upstreaming effort in #3326. Issue acceptance/RFC disposition for the wider Windows effort still needs maintainer confirmation.
Source comparison: GitLab main at ac7a3289, including its Windows tooling maintained through sync commit
23c166cb. This branch starts from GitHub maincc780d4e, independently of #3326. Source maintenance credit: Shailendra Singh; port and additional ARM64/cleanup fixes: Prekshi Vyas.Changes
The comparison retained newer upstream runtime behavior and did not restore obsolete internal documentation or demos. This PR records the concrete remaining validation delta found; it is not a claim of exhaustive equivalence with every historical GitLab commit.
Testing
mise run --skip-tools pre-commit: PASS on Windows ARM64, including Cargo lockfile checks, workspace/e2e Clippy, and governance-interceptor compilation. This is the documented native Windows task mode, not a check bypass.go test ./...insdk/go: PASS; the four failing Windows assertions from the combined-port checkout are addressed. Two POSIX-permission tests explicitly skip their unsupported assertions.mise run --skip-tools sdk:ts:ci: PASS, including code generation, lint, type checking, build, and 105 tests. Verified the final run used the pinned Vitest4.1.10and left the SDK package manifest/lockfile unchanged.git diff --cached --check: PASS. No generated SDK or line-ending-only changes included.mise run --skip-tools go:ci: FAIL atgo:proto-check; regenerated comments differ in list indentation/blank lines from the tracked bindings. No protocol fields differ in the observed comparison. Remaining aggregate stages are not claimed to pass.mise run --skip-tools test:e2e-parity: FAIL after the Bash/Python launcher succeeds; the current main fixture expects aguest_tls_caline absent from its generated v2 config. The fixture/generator are unchanged by this PR. Temporary launcher cleanup completed.Checklist